Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACP option for hiding attachments #9

Open
marcovo opened this issue Aug 30, 2015 · 2 comments
Open

ACP option for hiding attachments #9

marcovo opened this issue Aug 30, 2015 · 2 comments

Comments

@marcovo
Copy link
Owner

marcovo commented Aug 30, 2015

Make an ACP option for hiding ACP attachments.

https://www.phpbb.com/community/viewtopic.php?p=14140856#p14140856

@marcovo
Copy link
Owner Author

marcovo commented Sep 1, 2015

Attempted fix in commit: 52ed482

This also includes a bugfix for a problem that was actually mentioned in the very same post, that attachments were hidden regardless whether a [hide] bbcode was present or not.

I did not yet test if it works with inline attachments.

@marcovo
Copy link
Owner Author

marcovo commented Sep 2, 2015

Since the latest commit 101bf13 , inline attachments will be hidden if they are inside [hide] tags. Other attachments (e.g. non-inline ones) are hidden whenever there is a [hide] bbcode present in the text.

This probably is the best solution for attachments. Other solutions might be more prone to errors or false positives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant