Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnail youtube video #109

Open
dpizzuto opened this issue Jun 24, 2015 · 12 comments · May be fixed by #113
Open

Thumbnail youtube video #109

dpizzuto opened this issue Jun 24, 2015 · 12 comments · May be fixed by #113

Comments

@dpizzuto
Copy link

When I load the photogallery with correct youtube item, the thumbnails inside gallery have grey image and length of 00:00 sec. Vimeo's video haven't this issue.
Is it a known issue ?

@mythodeia
Copy link

maybe its because the youtube v2 is deprecated. #95

@dpizzuto
Copy link
Author

I saw that actually there isn't a workaraound for fix this issue, right ?

@mythodeia
Copy link

as far as i know not yet

@mariohahn
Copy link
Owner

I saw one implementing V3. But i can't find it now :(

@dpizzuto
Copy link
Author

I'll try to find out the new v3 api. I'll let you know. Please, keep this issue opened.

@dpizzuto
Copy link
Author

I found a solution: I had to integrate new v3 api with api key and new URLs. For now, I adapted the code for my goals that are thumbnail and video duration. As soon as possibile, I'll fork your project and push the new code with pull request. Keep issue opened until I finish the operations.

@chrismeats
Copy link

👍 This PR fixed the same issue that I was having. Hopefully something with this gets pulled into the master repo.

Although it does seem a little funny to have to edit one of the Pod files (MHGallery.m) to add your API key. Is it possible to load this value from plist value instead?

@mariohahn
Copy link
Owner

I don't like both of this ways... Maybe something have like this a just a Property:

extern void MHGalleryCustomLocalizationBlock(NSString *(^customLocalizationBlock)(NSString *stringToLocalize));

@dpizzuto
Copy link
Author

dpizzuto commented Jul 7, 2015

Yes Chris, isn't the best solution so far but was, as described, a quick & dirty solution for my purpose. A good way, in my opinion, maybe to have a property to set in a SharedObject.

@mariohahn
Copy link
Owner

property would be the best (:

@chrismeats chrismeats linked a pull request Jul 7, 2015 that will close this issue
@chrismeats
Copy link

I went ahead and took a stab at this using MHGalleryCustomLocalizationBlock.

@okulak
Copy link

okulak commented Nov 17, 2015

Guys, does app support all possible youtube urls for downloading thumbnails and playing video? I found an issue with urls:
"http://youtu.be/Jmb7NgNouoM"
or
"https://www.youtube.com/embed/DheulkmtR7Y?vq=hd720&rel=0&showinfo=0&modestbranding=1&enablejsapi=1&origin=http%3A%2F%2Fwww.shyp.com"

BTW the same issue with Vimeo for link:
"https://player.vimeo.com/video/99743076?api=1"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@mariohahn @mythodeia @chrismeats @okulak @dpizzuto and others