Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with variants properly #10

Open
markasoftware opened this issue Mar 14, 2017 · 1 comment
Open

Deal with variants properly #10

markasoftware opened this issue Mar 14, 2017 · 1 comment

Comments

@markasoftware
Copy link
Owner

markasoftware commented Mar 14, 2017

For example, many gpus have multiple options for vram capacity. Having separate "parts" for each one is ok, but it could get unwieldy with more than 2 variants (for example, nvidia increasing the memory clock rate for the gtx 1060 or something which already has 2 vram options would result in 4 options. Maybe, if multiple variants, options show up after click, sliding up from bottom with css transition? Multiple .yaml files and parts internally is a good idea though, and it could make the subtext weird...needs more brainstorming...also with relation to filtering, although it's not a huge issue I think, if done like this the user can probably figure out which variant meets their criteria without too much pain

@markasoftware
Copy link
Owner Author

Will have "global" variants, e.g different gb on cards, and "local" variants, e.g different graphics card manufacturers (e.g, sapphire and xfx). These screenshots are for local variants. The local variant dropdowns will show on all selected parts with local variants, but only one can be open at a time. The current plan for how to display the local variants is a separate table below the main spec one which shows differences between variants of the same part. Will have red-selected styling on selected variants. Opening a different dropdown closes the first one, and deselects all variants in it.
dankish-dropdown-full
dank-arrow-down
Small design things: table borders seem too long, VARIANTS: header needs to be made a better font/thickness/whatever, might be a good idea to use svg instead of unicode for arrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant