From 06933a2bdf5dd7f3515b165950ecfcc939509aa5 Mon Sep 17 00:00:00 2001
From: Ryan Turnquist <rturnq@gmail.com>
Date: Thu, 4 Apr 2024 10:43:34 -0700
Subject: [PATCH] fix: inconsistent test

---
 .../build.expected.loading.0.html             |  1 +
 .../build.expected.loading.1.html             |  2 ++
 .../build.expected.loading.2.html             |  6 ++--
 .../build.expected.loading.3.html             |  4 ++-
 .../build.expected.loading.4.html             | 33 +++++++++++++++++++
 .../build.expected.step-0.0.html              |  2 ++
 .../__snapshots__/dev.expected.loading.0.html |  1 +
 .../__snapshots__/dev.expected.loading.1.html |  2 ++
 .../__snapshots__/dev.expected.loading.2.html |  2 ++
 .../__snapshots__/dev.expected.loading.3.html |  2 ++
 .../__snapshots__/dev.expected.loading.4.html |  2 ++
 .../__snapshots__/dev.expected.step-0.0.html  |  2 ++
 .../server.mjs                                |  5 +--
 .../src/components/class-component.marko      |  4 +--
 14 files changed, 57 insertions(+), 11 deletions(-)
 create mode 100644 src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/build.expected.loading.4.html

diff --git a/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/build.expected.loading.0.html b/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/build.expected.loading.0.html
index 9b38277..7cbb889 100644
--- a/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/build.expected.loading.0.html
+++ b/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/build.expected.loading.0.html
@@ -14,6 +14,7 @@
       src="/assets/logo-[hash].svg"
     />
     <script
+      async=""
       src="./script.js"
     />
   </div>
diff --git a/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/build.expected.loading.1.html b/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/build.expected.loading.1.html
index 3b4b888..02a3faf 100644
--- a/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/build.expected.loading.1.html
+++ b/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/build.expected.loading.1.html
@@ -14,9 +14,11 @@
       src="/assets/logo-[hash].svg"
     />
     <script
+      async=""
       src="./script.js"
     />
     <script
+      async=""
       src="/assets/script-[hash].js"
     />
   </div>
diff --git a/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/build.expected.loading.2.html b/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/build.expected.loading.2.html
index 61a5df4..0004dc2 100644
--- a/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/build.expected.loading.2.html
+++ b/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/build.expected.loading.2.html
@@ -14,18 +14,16 @@
       src="/assets/logo-[hash].svg"
     />
     <script
+      async=""
       src="./script.js"
     />
     <script
+      async=""
       src="/assets/script-[hash].js"
     />
     <link
       href="./styles.css"
       rel="stylesheet"
     />
-    <link
-      href="/assets/styles-[hash].css"
-      rel="stylesheet"
-    />
   </div>
 </div>
\ No newline at end of file
diff --git a/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/build.expected.loading.3.html b/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/build.expected.loading.3.html
index cea93c0..b2e02a1 100644
--- a/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/build.expected.loading.3.html
+++ b/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/build.expected.loading.3.html
@@ -4,7 +4,7 @@
   <div
     id="clickable"
   >
-    Mounted: true Clicks: 0
+    Mounted: false Clicks: 0
     <img
       alt="logo"
       src="/assets/logo-[hash].svg"
@@ -14,9 +14,11 @@
       src="/assets/logo-[hash].svg"
     />
     <script
+      async=""
       src="./script.js"
     />
     <script
+      async=""
       src="/assets/script-[hash].js"
     />
     <link
diff --git a/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/build.expected.loading.4.html b/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/build.expected.loading.4.html
new file mode 100644
index 0000000..ff89ba0
--- /dev/null
+++ b/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/build.expected.loading.4.html
@@ -0,0 +1,33 @@
+<div
+  id="implicit"
+>
+  <div
+    id="clickable"
+  >
+    Mounted: true Clicks: 0
+    <img
+      alt="logo"
+      src="/assets/logo-[hash].svg"
+    />
+    <img
+      alt="logo"
+      src="/assets/logo-[hash].svg"
+    />
+    <script
+      async=""
+      src="./script.js"
+    />
+    <script
+      async=""
+      src="/assets/script-[hash].js"
+    />
+    <link
+      href="./styles.css"
+      rel="stylesheet"
+    />
+    <link
+      href="/assets/styles-[hash].css"
+      rel="stylesheet"
+    />
+  </div>
+</div>
\ No newline at end of file
diff --git a/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/build.expected.step-0.0.html b/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/build.expected.step-0.0.html
index 55e417e..068bbd2 100644
--- a/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/build.expected.step-0.0.html
+++ b/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/build.expected.step-0.0.html
@@ -14,9 +14,11 @@
       src="/assets/logo-[hash].svg"
     />
     <script
+      async=""
       src="./script.js"
     />
     <script
+      async=""
       src="/assets/script-[hash].js"
     />
     <link
diff --git a/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/dev.expected.loading.0.html b/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/dev.expected.loading.0.html
index 6063ef5..de9a732 100644
--- a/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/dev.expected.loading.0.html
+++ b/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/dev.expected.loading.0.html
@@ -14,6 +14,7 @@
       src="/src/components/logo.svg"
     />
     <script
+      async=""
       src="./script.js"
     />
   </div>
diff --git a/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/dev.expected.loading.1.html b/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/dev.expected.loading.1.html
index 2337b5c..ae8c852 100644
--- a/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/dev.expected.loading.1.html
+++ b/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/dev.expected.loading.1.html
@@ -14,9 +14,11 @@
       src="/src/components/logo.svg"
     />
     <script
+      async=""
       src="./script.js"
     />
     <script
+      async=""
       src="/src/components/script.js"
     />
   </div>
diff --git a/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/dev.expected.loading.2.html b/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/dev.expected.loading.2.html
index c752795..abdd81b 100644
--- a/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/dev.expected.loading.2.html
+++ b/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/dev.expected.loading.2.html
@@ -14,9 +14,11 @@
       src="/src/components/logo.svg"
     />
     <script
+      async=""
       src="./script.js"
     />
     <script
+      async=""
       src="/src/components/script.js"
     />
     <link
diff --git a/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/dev.expected.loading.3.html b/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/dev.expected.loading.3.html
index 463be8a..e8c5251 100644
--- a/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/dev.expected.loading.3.html
+++ b/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/dev.expected.loading.3.html
@@ -14,9 +14,11 @@
       src="/src/components/logo.svg"
     />
     <script
+      async=""
       src="./script.js"
     />
     <script
+      async=""
       src="/src/components/script.js"
     />
     <link
diff --git a/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/dev.expected.loading.4.html b/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/dev.expected.loading.4.html
index bce6c5d..18ab5b9 100644
--- a/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/dev.expected.loading.4.html
+++ b/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/dev.expected.loading.4.html
@@ -14,9 +14,11 @@
       src="/src/components/logo.svg"
     />
     <script
+      async=""
       src="./script.js"
     />
     <script
+      async=""
       src="/src/components/script.js"
     />
     <link
diff --git a/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/dev.expected.step-0.0.html b/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/dev.expected.step-0.0.html
index f44563e..73c4676 100644
--- a/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/dev.expected.step-0.0.html
+++ b/src/__tests__/fixtures/isomorphic-relative-asset-import/__snapshots__/dev.expected.step-0.0.html
@@ -14,9 +14,11 @@
       src="/src/components/logo.svg"
     />
     <script
+      async=""
       src="./script.js"
     />
     <script
+      async=""
       src="/src/components/script.js"
     />
     <link
diff --git a/src/__tests__/fixtures/isomorphic-relative-asset-import/server.mjs b/src/__tests__/fixtures/isomorphic-relative-asset-import/server.mjs
index 2b57bb6..395a9a4 100644
--- a/src/__tests__/fixtures/isomorphic-relative-asset-import/server.mjs
+++ b/src/__tests__/fixtures/isomorphic-relative-asset-import/server.mjs
@@ -3,10 +3,7 @@ import path from "path";
 import url from "url";
 import { createServer } from "http";
 import serve from "serve-handler";
-
-globalThis.assetsPath = "/my-prefix/";
-// dyanmic import so globalThis.assetsPath can be set prior to the imported code executing
-const { handler } = await import("./dist/index.mjs");
+import { handler } from "./dist/index.mjs";
 
 const __dirname = path.dirname(url.fileURLToPath(import.meta.url));
 const serveOpts = { public: path.resolve(__dirname, "dist") };
diff --git a/src/__tests__/fixtures/isomorphic-relative-asset-import/src/components/class-component.marko b/src/__tests__/fixtures/isomorphic-relative-asset-import/src/components/class-component.marko
index 790d60d..c4c50c1 100644
--- a/src/__tests__/fixtures/isomorphic-relative-asset-import/src/components/class-component.marko
+++ b/src/__tests__/fixtures/isomorphic-relative-asset-import/src/components/class-component.marko
@@ -19,8 +19,8 @@ class {
 
   <img src="./logo.svg" alt="logo">
   <img src="./logo.svg?url" alt="logo">
-  <script src="./script.js"/>
-  <script src="./script.js?url"/>
+  <script src="./script.js" async/>
+  <script src="./script.js?url" async/>
   <link rel="stylesheet" href="./styles.css">
   <link rel="stylesheet" href="./styles.css?url">
 </div>