Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not an issue, but an enhancement questoin #4

Open
bondjw07 opened this issue Oct 29, 2023 · 1 comment
Open

Not an issue, but an enhancement questoin #4

bondjw07 opened this issue Oct 29, 2023 · 1 comment

Comments

@bondjw07
Copy link

Hey there, love this design. It was only missing one thing for me, and that was a hole so I could have them all hanging on a a beaded pull chain. I made the change to the .scad file and I was wondering if 1. you were interested in it and 2. if so, how you would like me to share it. I can do a new pull request and just name it FilamentSamples_withHole.scad if you want. I doubt you'd want to replace your existing file.

Anyhow, have a great one!

Screenshot 2023-10-29 at 3 25 41 AM
@markusdd
Copy link
Owner

I think that addition makes sense for people who want to keep their samples on a small chain or something like that.

Please make a PR and also add an appropriate hint in the README for it. The filename you proposed is fine.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants