EcommercePaymentResponse -- Double encoded url

[GlenCarlier]

For a while I've had the trouble of EcommercePaymentResponse objects not being valid using:
if($ecommercePaymentResponse->isValid($shaComposer) && $ecommercePaymentResponse->isSuccessful())

The problem here was that the redirect url (that I get from Ogone was double encoded).
Ex.
dot was '%252E' instead of '%2E'

This resulted in the $shaString being incorrect so it wouldnt be the same as the shaSign I got with the request (and thus isValid resulting in false).

It might have been a misconfiguration of Ogone on my part but for now I fixed it by urldecoding all the values from the request before creating the EcommercePaymentResponse.

A quick fix might be to do the following:
AllParametersShaComposer.php

public function compose(array $parameters)
    {
        foreach($this->parameterFilters as $parameterFilter) {
            $parameters = $parameterFilter->filter($parameters);
        }

        ksort($parameters);

        // compose SHA string
        $shaString = '';
        foreach($parameters as $key => $value) {
            $shaString .= $key . '=' . urldecode($value) . $this->passphrase;
        }

        return strtoupper(hash($this->hashAlgorithm, $shaString));
    }

instead of

public function compose(array $parameters)
    {
        foreach($this->parameterFilters as $parameterFilter) {
            $parameters = $parameterFilter->filter($parameters);
        }

        ksort($parameters);

        // compose SHA string
        $shaString = '';
        foreach($parameters as $key => $value) {
            $shaString .= $key . '=' . $value . $this->passphrase;
        }

        return strtoupper(hash($this->hashAlgorithm, $shaString));
    }

I don't know what the implication of this "fix" are, just wanted to give you guys an update on this particular problem.