Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure artist description links are good #60

Open
Nedlinin opened this issue Mar 30, 2020 · 3 comments
Open

Ensure artist description links are good #60

Nedlinin opened this issue Mar 30, 2020 · 3 comments

Comments

@Nedlinin
Copy link
Collaborator

https://www.reddit.com/r/listentothis/comments/fru372/brooke_waggoner_lungs_speed_lungs_sped_indie_folk/flxn6v6/

The artist description pulled from discogs has a link for lyrics. This link redirects multiple times and ends up on an adfilled hellscape of a website.

Maybe we should whitelist a handful of sites and remove any links that don't match that whitelist? For instance, the main socials, amazon, wiki, etc.

@Nedlinin
Copy link
Collaborator Author

Hmm just realized that won't work for the ones that contain links to their official websites. Thoughts?

@ghost
Copy link

ghost commented Apr 1, 2020

Happened the first time for me too, but the link seems to work fine now. I'm confused.

@martijnboers
Copy link
Owner

We could work with a blacklist, think that's would solve the issue for artist websites. I hope Musicbrainz doesn't have too many references to these kinds of shitty sites

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants