Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The packaging via CPack was gone #69

Closed
KOLANICH opened this issue Jan 21, 2023 · 2 comments · Fixed by #73
Closed

The packaging via CPack was gone #69

KOLANICH opened this issue Jan 21, 2023 · 2 comments · Fixed by #73
Assignees
@martin-olivier
Labels
enhancement New feature or request

Comments

@KOLANICH
Copy link
Contributor

KOLANICH commented Jan 21, 2023 •
edited
Loading

The packaging via CPack was gone in 3c748b8 without any words about it, but fix: CMakeLists.txt. It is unclear if it got gone intentionally or accidentally.
@martin-olivier martin-olivier self-assigned this Sep 19, 2023
@martin-olivier martin-olivier added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Sep 19, 2023
@martin-olivier
Copy link
Owner

Hello, @KOLANICH, sorry for the late response.
Back at the time, I didn't knew how to use CPack, and to be sure that this does not cause security problems, I preferred to remove it.

Since I know to use it a bit now, fell free to provide a PR to restore CPack for this project.

@martin-olivier
Copy link
Owner

I have restored CPack support on the following branch:

https://github.com/martin-olivier/dylib/tree/69-the-packaging-via-cpack-was-gone

@martin-olivier martin-olivier linked a pull request Oct 13, 2023 that will close this issue
69 the packaging via cpack was gone #73
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martin-olivier martin-olivier

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

69 the packaging via cpack was gone martin-olivier/dylib
2 participants
@KOLANICH @martin-olivier