Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility issues with LanguageSwitcher component #68

Open
dagoss opened this issue Nov 28, 2023 · 1 comment
Open

Accessibility issues with LanguageSwitcher component #68

dagoss opened this issue Nov 28, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dagoss
Copy link

dagoss commented Nov 28, 2023

It looks like the <LanguageSwitcher> component cannot be accessed by keyboard. While it identifies itself as a button using the role attribute, since it's a span, the user can't tab to it. It also won't appear appropriately in the accessibility tree.

Can I ask why the component is using a <span> instead of a <Link> or <button>? Those would be more semantically appropriate and be more accessible to users (keyboard focus, able to activate by keyboard, appearing the accessibility tree, etc).

@martinkr
Copy link
Owner

Hi @dagoss,

Thank you for your contribution. I've been busy with version 3 and the app router support.
I'll consider your suggestion for the next minor release version.

Cheers!

@martinkr martinkr modified the milestones: 3.0.0, 3.1.0 Dec 14, 2023
@martinkr martinkr added the enhancement New feature or request label Dec 14, 2023
@martinkr martinkr self-assigned this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants