Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last project update #119

Closed
wants to merge 1 commit into from
Closed

Conversation

Ben-Rey
Copy link
Collaborator

@Ben-Rey Ben-Rey commented Sep 23, 2024

No description provided.

@Ben-Rey Ben-Rey linked an issue Sep 23, 2024 that may be closed by this pull request
Copy link
Member

@thomas-senechal thomas-senechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, only 2 small comments

@@ -6,3 +6,4 @@ export const CHUNK_NB_TAG = k.nextKey(); // 2 as u8
export const METADATA_TAG = k.nextKey(); // 3 as u8
export const MAX_STORAGE_VALUE_SIZE = k.nextKey(); // 4 as u8
export const FILES_PATH_LIST = new ConstantManager<Array<string>, u8>(k); // k will be 5 as u8
export const LAST_PROJECT_UPDATE = new ConstantManager<u64, u8>(k); // k will be 5 as u8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be 6?

Suggested change
export const LAST_PROJECT_UPDATE = new ConstantManager<u64, u8>(k); // k will be 5 as u8
export const LAST_PROJECT_UPDATE = new ConstantManager<u64, u8>(k); // k will be 6 as u8

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty file, useful ?

@Ben-Rey Ben-Rey closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get last update by contract
2 participants