Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double reference to checksum/config-secrets #66

Closed
ryphon opened this issue Apr 25, 2023 · 2 comments
Closed

Double reference to checksum/config-secrets #66

ryphon opened this issue Apr 25, 2023 · 2 comments

Comments

@ryphon
Copy link

ryphon commented Apr 25, 2023

checksum/config-secrets: {{ include ( print $.Template.BasePath "/secret-smtp.yaml" ) $context | sha256sum | quote }}

vs

checksum/config-secrets: {{ include ( print $.Template.BasePath "/secrets.yaml" ) . | sha256sum | quote }}

Not sure how you'll want this resolved. You define the config-secrets annotation in both the helpers and that specific deployment. Unfortunately that means the values are doubled up, and k8s does not like it when that happens very much. Maybe remove the helpers, and let the sidekiq deploy do the annotation without the helper function?

Happy to do a PR and test, but don't know what would be preferred in this case.

@ryphon
Copy link
Author

ryphon commented Apr 25, 2023

The link didn't give a lot of context, but the first link, one line up has

{{- include "mastodon.rollingPodAnnotations" $context | nindent 8 }}

@ryphon ryphon closed this as completed Apr 25, 2023
@ryphon
Copy link
Author

ryphon commented Apr 25, 2023

dupe, closed in favor of #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant