Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File Operations dialog incorrectly displays throughput speed when files are queued #1420

Open
dominix opened this issue Jun 26, 2020 · 4 comments · May be fixed by #1758
Open

File Operations dialog incorrectly displays throughput speed when files are queued #1420

dominix opened this issue Jun 26, 2020 · 4 comments · May be fixed by #1758
Labels
confirmed

Comments

@dominix
Copy link

dominix commented Jun 26, 2020 •
edited
Loading

Expected behaviour

display real copy speed in octet/s since the beginning of the copy of the current file proceeded.

Actual behaviour

display an average speed deducted from time since the beginning of the copy of the first file in the pool, instead of the beginning of copy of the current file been proceeded.

Steps to reproduce the behaviour

copy a file to destination, then add another file to copy to the same destination so the operations is queued, then notice the difference in displayed throughput in the file operations window when the second file is copied.

MATE general version

1.24.0

Package version

caja 1.24.0-1 amd64

Linux Distribution

ubuntu 20.04 LTS

Link to downstream report of your Distribution
@dominix
Copy link
Author

dominix commented Jun 26, 2020

one solution could be to not reset the speed counter between files when they are queued, so the average will be related to some realistic throughput.
or, if you reset the speed counter, please reset both speed and time counter. I have the feeling that currently only the speed counter is reset.

@lukefromdc
Copy link
Member

I've noticed this for years

@jaimeaxel
Copy link

Any progress on this one?
This has been happening from way before the bug report and is still happening in 1.26+.

@lukefromdc
Copy link
Member

I haven't worked on this myself, being rather task-saturated. If this does NOT happen on either Nemo or on Nautilus though, that would mean one of them found a fix we could port over. If it still happens on all three, it's a pre-fork Nautilus bug nobody ever found a fix for

basicmaster added a commit to basicmaster/caja that referenced this issue Dec 31, 2023
@basicmaster
caja-file-operations: stop timer when waiting
ab55e0b 
When a copy/move operation is created while another operation is already
active, the new operation is queued. As the (already running) operation
timer of the new operation is not stopped during the waiting period,
that period is (erroneously) included in the transfer rate calculation
and leads to initially low/slowly increasing transfer rates be shown.

Hence stop the operation timer when the (queued) operation is waiting.

Fixes mate-desktop#1420 and mate-desktop#1623.
basicmaster added a commit to basicmaster/caja that referenced this issue Dec 31, 2023
@basicmaster
caja-file-operations: stop timer when waiting
5b2192f 
When a copy/move operation is created while another operation is already
active, the new operation is queued. As the (already running) operation
timer of the new operation is not stopped during the waiting period,
that period is (erroneously) included in the transfer rate calculation
and leads to initially low/slowly increasing transfer rates be shown.

Hence stop the operation timer when the (queued) operation is waiting.

Fixes mate-desktop#1420 and mate-desktop#1623.
@basicmaster basicmaster linked a pull request Dec 31, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

caja-file-operations: fixes the operations timer handling basicmaster/caja
3 participants
@dominix @lukefromdc @jaimeaxel