Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"icon file not found" icon shown for weather applet; tooltip is "broken clouds", at night #535

Open
adrnde opened this issue Nov 6, 2020 · 7 comments

Comments

@adrnde
Copy link

adrnde commented Nov 6, 2020

Expected behaviour

Should be showing partial cloud icon perhaps with a partial moon

Actual behaviour

showing rectangle with red slashed circle; temperature displayed correctly beneath
Mouseover brings up city with "broken clouds" as expected

Steps to reproduce the behaviour

Weather Report 1.24.0, on fresh install of Linux Mint 20
Need "broken clouds" as weather.
Switched to diff city with clear weather, shows moon sliver
Trying different cities:
overcast, shows two overlapping clouds
mist shows wavy lines, as expected
As of when trying this, Nov 6 02:00 EST, Trondheim, Norway also had 'broken clouds',
and also displayed the broken icon

MATE general version

1.24.0

WeatherApp-Broken_Clouds

Package version

Mate-weather-app 1.24.0
Mate-panel 1.24.0

Linux Distribution

Linux Mint 20
WeatherApp-Broken_Clouds

Link to downstream report of your Distribution

@lukefromdc
Copy link
Member

What icon theme are you using? We have a set of "weather-few-clouds" icons in the default mate icon theme which menta inherits from as well. Looking at the "weather.c" source file in libmateweather(where these icons are chosen) shows this block:


    case SKY_BROKEN:
    case SKY_SCATTERED:
    case SKY_FEW:
	if (daytime)
	    return "weather-few-clouds";
	else {
	    icon = g_stpcpy(icon_buffer, "weather-few-clouds-night");
	    break;
	}

meaning the "weather-few-clouds" or "weather-few-clouds-night" icon which we provide should display unless you are using an icon theme that does not provide it and does not inherit from mate-or you have found a bug in libmateweather.

@ssrublev
Copy link

I've seen such problems with weather icons in Ubuntu-MATE, but not always: sometimes icon present, sometimes not

@ssrublev
Copy link

ssrublev commented Dec 2, 2020

image

a picture of constantly missing icon in MATE systray (which is hardly broken in Ubuntu but works well in Fedora)

@rbuj
Copy link
Contributor

rbuj commented Dec 2, 2020

@ssrublev the icon shown in your screenshot belongs to indicator-datetime.

@adrnde
Copy link
Author

adrnde commented Dec 3, 2020

Tracking days when the weather icon works / does not, icons go missing at night under conditions of "few clouds" or "broken clouds".

It looks like the icon folder "Mint-X" is the one being used, and it does have an icon for
weather-few-clouds-night.

On occasion the weather app will not update at all, instead just sitting in 'updating' status indefinitely. The text based "weather" from package "weather-util", which gets data from the same source, always works. Perhaps there is some fiddling detail in the received data that isn't always what is expected?

@rbuj
Copy link
Contributor

rbuj commented Dec 3, 2020

@adrnde There may be several reasons which may prevent fetching weather data. If the command line application weather from weather-util package cannot get the weather data it uses a cache to display the last successfully captured data.

https://www.yuggoth.org/gitweb?p=weather.git;a=tree

The weather applet sets the "Updating..." tooltip just before updating the weather information:

gtk_widget_set_tooltip_text (GTK_WIDGET(gw_applet->applet), _("Updating..."));

It's updated only if it's able to retrieve valid data:

gtk_widget_set_tooltip_text (GTK_WIDGET (gw_applet->applet), s);

@rbuj
Copy link
Contributor

rbuj commented Dec 3, 2020

It may be related to mate-desktop/libmateweather#91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants