Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve --image/-im flag #58

Open
mateosss opened this issue Mar 15, 2021 · 4 comments
Open

Improve --image/-im flag #58

mateosss opened this issue Mar 15, 2021 · 4 comments

Comments

@mateosss
Copy link
Owner

See issues discussed on #57 with the current feature.

@heyzec
Copy link
Collaborator

heyzec commented Apr 2, 2021

For ease of reference, these are the current issues:

  1. When script is rerun (either with new image or without any image at all), the old image will remain in /boot/grub/themes/Matter. A similar approach to what is being done for icons and fonts might be useful here.

  2. Background image will not show when using with the -b -t flags for previewing.

@wiredmatt
Copy link

It worked perfectly for me, I even tested with multiple backgrounds, icons and fonts, what's the exact problem with this?

Tested on Manjaro Linux (EFI GPT filesystem):
image

@mateosss
Copy link
Owner Author

mateosss commented Jan 21, 2022

Indeed the feature works great. The issues were the two listed in the last comment from @heyzec, although they are background issues and do not affect normal usage.

For once, point 1 in that comment means you will have multiple unused images being stored in your /boot/grub/themes/Matter directory while point 2 forces you to test the theme by rebooting instead of the quicker testing procedure with -b -t flags.

@wiredmatt
Copy link

Interesting, the -b -t flags worked for me without issues. Manjaro uses a different version of grub2 (their own), so it might be the case that it just works with Manjaro, since I've tried previewing in Fedora and Arch, but couldn't preview the GRUB theme even without a background image.

Regarding point 1, you could make the script rename the background image to background.`jpg, so when it copies over to /boot/grub/themes/Matter, whatever there was before will be automatically replaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants