Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

Type scale generator uses wrong caption #46

Open
mikekosulin opened this issue May 17, 2020 · 2 comments
Open

Type scale generator uses wrong caption #46

mikekosulin opened this issue May 17, 2020 · 2 comments

Comments

@mikekosulin
Copy link

mikekosulin commented May 17, 2020

The dart code for the Type scale generator should use right caption for these fonts.

Wrong:
GoogleFonts.iBMPlexSans()

Correct:
GoogleFonts.ibmPlexSans()

Same for all:

Alegreya Sans SC
Alegreya SC
Almendra SC
Carrois Gothic SC
Cormorant SC
DM Mono
DM Sans
DM Serif Display
DM Serif Text
EB Garamond
Holtwood One SC
IBM Plex Mono
IBM Plex Sans
IBM Plex Sans Condensed
IBM Plex Serif
IM Fell Double Pica
IM Fell Double Pica SC
IM Fell DW Pica
IM Fell DW Pica SC
IM Fell English
IM Fell English SC
IM Fell French Canon
IM Fell French Canon SC
IM Fell Great Primer
IM Fell Great Primer SC
Marcellus SC
Mate SC

NTR
Old Standard TT
Playfair Display SC
PT Mono
PT Sans
PT Sans Caption
PT Sans Narrow
PT Serif
PT Serif Caption
Spectral SC
Vollkorn SC
ZCOOL XiaoWei

Funny fact:
ABeeZee works great.
ABeeZee -> aBeeZee

@mikekosulin
Copy link
Author

also noticed that only Noto Sans is available.

Noto Sans HK
Noto Sans JP
Noto Sans KR
Noto Sans SC
Noto Sans TC

only Noto Serif is available

Noto Serif JP
Noto Serif KR
Noto Serif SC
Noto Serif TC

@mikekosulin
Copy link
Author

And generator doesn't work for
GFS Didot
GFS Neohellenic

I choose these fonts at Type scale generator, but state doesn't change

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant