Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating better hints for the icon color check workflow #2661

Open
okineadev opened this issue Nov 1, 2024 · 0 comments
Open

Creating better hints for the icon color check workflow #2661

okineadev opened this issue Nov 1, 2024 · 0 comments
Assignees
Labels

Comments

@okineadev
Copy link
Member

If I see an error in the icon color check workflow, I have to go to its log to find out which colors need to be replaced to match the Material Design palette

I think it would be better if it sent a comment with color hints something like this:


🎨❌ Error in icon colors

  • luau.svg:

    • Invalid color #00A2FF
      • Suggestions: #42A5F5, #039BE5, #03A9F4, #2196F3, #00B0FF
    • Invalid color white
      • Suggestions: #FAFAFA, #F5F5F5, #EEEEEE, #ECEFF1, #EFEBE9
  • rbxmk.svg:

    • Invalid color #13BD2A
      • Suggestions: #00C853, #4CAF50, #66BB6A, #7CB342, #43A047
  • ...


Useful links:


It should work similar to icon-review.yml, if there is already such a comment, then replace it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants