From 1217346b9416e6e55c83c6e9295f6aed001e852e Mon Sep 17 00:00:00 2001 From: Material Eng Date: Thu, 7 Dec 2023 13:55:13 -0800 Subject: [PATCH] Change QuanizerResult::color_to_count to match RankedSuggestion signature PiperOrigin-RevId: 588900384 --- cpp/quantize/celebi_test.cc | 18 +++++++++--------- cpp/quantize/wsmeans.cc | 2 +- cpp/quantize/wsmeans.h | 2 +- cpp/quantize/wsmeans_test.cc | 10 +++++----- 4 files changed, 16 insertions(+), 16 deletions(-) diff --git a/cpp/quantize/celebi_test.cc b/cpp/quantize/celebi_test.cc index a7ad55d3..43177641 100644 --- a/cpp/quantize/celebi_test.cc +++ b/cpp/quantize/celebi_test.cc @@ -50,7 +50,7 @@ TEST(CelebiTest, OneRed) { pixels.push_back(0xffff0000); QuantizerResult result = QuantizeCelebi(pixels, 256); EXPECT_EQ(result.color_to_count.size(), 1u); - EXPECT_EQ(result.color_to_count[0xffff0000], 1); + EXPECT_EQ(result.color_to_count[0xffff0000], 1u); } TEST(CelebiTest, OneGreen) { @@ -58,7 +58,7 @@ TEST(CelebiTest, OneGreen) { pixels.push_back(0xff00ff00); QuantizerResult result = QuantizeCelebi(pixels, 256); EXPECT_EQ(result.color_to_count.size(), 1u); - EXPECT_EQ(result.color_to_count[0xff00ff00], 1); + EXPECT_EQ(result.color_to_count[0xff00ff00], 1u); } TEST(CelebiTest, OneBlue) { @@ -66,7 +66,7 @@ TEST(CelebiTest, OneBlue) { pixels.push_back(0xff0000ff); QuantizerResult result = QuantizeCelebi(pixels, 256); EXPECT_EQ(result.color_to_count.size(), 1u); - EXPECT_EQ(result.color_to_count[0xff0000ff], 1); + EXPECT_EQ(result.color_to_count[0xff0000ff], 1u); } TEST(CelebiTest, FiveBlue) { @@ -76,7 +76,7 @@ TEST(CelebiTest, FiveBlue) { } QuantizerResult result = QuantizeCelebi(pixels, 256); EXPECT_EQ(result.color_to_count.size(), 1u); - EXPECT_EQ(result.color_to_count[0xff0000ff], 5); + EXPECT_EQ(result.color_to_count[0xff0000ff], 5u); } TEST(CelebiTest, OneRedOneGreenOneBlue) { @@ -86,9 +86,9 @@ TEST(CelebiTest, OneRedOneGreenOneBlue) { pixels.push_back(0xff0000ff); QuantizerResult result = QuantizeCelebi(pixels, 256); EXPECT_EQ(result.color_to_count.size(), 3u); - EXPECT_EQ(result.color_to_count[0xffff0000], 1); - EXPECT_EQ(result.color_to_count[0xff00ff00], 1); - EXPECT_EQ(result.color_to_count[0xff0000ff], 1); + EXPECT_EQ(result.color_to_count[0xffff0000], 1u); + EXPECT_EQ(result.color_to_count[0xff00ff00], 1u); + EXPECT_EQ(result.color_to_count[0xff0000ff], 1u); } TEST(CelebiTest, TwoRedThreeGreen) { @@ -100,8 +100,8 @@ TEST(CelebiTest, TwoRedThreeGreen) { pixels.push_back(0xff00ff00); QuantizerResult result = QuantizeCelebi(pixels, 256); EXPECT_EQ(result.color_to_count.size(), 2u); - EXPECT_EQ(result.color_to_count[0xffff0000], 2); - EXPECT_EQ(result.color_to_count[0xff00ff00], 3); + EXPECT_EQ(result.color_to_count[0xffff0000], 2u); + EXPECT_EQ(result.color_to_count[0xff00ff00], 3u); } TEST(CelebiTest, NoColors) { diff --git a/cpp/quantize/wsmeans.cc b/cpp/quantize/wsmeans.cc index 92ad8602..f6381b78 100644 --- a/cpp/quantize/wsmeans.cc +++ b/cpp/quantize/wsmeans.cc @@ -247,7 +247,7 @@ QuantizerResult QuantizeWsmeans(const std::vector& input_pixels, // Constructs the quantizer result to return. - std::map color_to_count; + std::map color_to_count; for (size_t i = 0; i < swatches.size(); i++) { color_to_count[swatches[i].argb] = swatches[i].population; } diff --git a/cpp/quantize/wsmeans.h b/cpp/quantize/wsmeans.h index 72aea722..807ef723 100644 --- a/cpp/quantize/wsmeans.h +++ b/cpp/quantize/wsmeans.h @@ -26,7 +26,7 @@ namespace material_color_utilities { struct QuantizerResult { - std::map color_to_count; + std::map color_to_count; std::map input_pixel_to_cluster_pixel; }; diff --git a/cpp/quantize/wsmeans_test.cc b/cpp/quantize/wsmeans_test.cc index 901cdeb3..083cdd44 100644 --- a/cpp/quantize/wsmeans_test.cc +++ b/cpp/quantize/wsmeans_test.cc @@ -51,7 +51,7 @@ TEST(WsmeansTest, OneRedAndO) { std::vector starting_clusters; QuantizerResult result = QuantizeWsmeans(pixels, starting_clusters, 256); EXPECT_EQ(result.color_to_count.size(), 1u); - EXPECT_EQ(result.color_to_count[0xff141216], 1); + EXPECT_EQ(result.color_to_count[0xff141216], 1u); } TEST(WsmeansTest, OneRed) { @@ -60,7 +60,7 @@ TEST(WsmeansTest, OneRed) { std::vector starting_clusters; QuantizerResult result = QuantizeWsmeans(pixels, starting_clusters, 256); EXPECT_EQ(result.color_to_count.size(), 1u); - EXPECT_EQ(result.color_to_count[0xffff0000], 1); + EXPECT_EQ(result.color_to_count[0xffff0000], 1u); } TEST(WsmeansTest, OneGreen) { @@ -69,7 +69,7 @@ TEST(WsmeansTest, OneGreen) { std::vector starting_clusters; QuantizerResult result = QuantizeWsmeans(pixels, starting_clusters, 256); EXPECT_EQ(result.color_to_count.size(), 1u); - EXPECT_EQ(result.color_to_count[0xff00ff00], 1); + EXPECT_EQ(result.color_to_count[0xff00ff00], 1u); } TEST(WsmeansTest, OneBlue) { @@ -78,7 +78,7 @@ TEST(WsmeansTest, OneBlue) { std::vector starting_clusters; QuantizerResult result = QuantizeWsmeans(pixels, starting_clusters, 256); EXPECT_EQ(result.color_to_count.size(), 1u); - EXPECT_EQ(result.color_to_count[0xff0000ff], 1); + EXPECT_EQ(result.color_to_count[0xff0000ff], 1u); } TEST(WsmeansTest, FiveBlue) { @@ -89,7 +89,7 @@ TEST(WsmeansTest, FiveBlue) { std::vector starting_clusters; QuantizerResult result = QuantizeWsmeans(pixels, starting_clusters, 256); EXPECT_EQ(result.color_to_count.size(), 1u); - EXPECT_EQ(result.color_to_count[0xff0000ff], 5); + EXPECT_EQ(result.color_to_count[0xff0000ff], 5u); } } // namespace