Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalized mesh support for diffusion module #15

Open
nury12n opened this issue Dec 11, 2024 · 0 comments
Open

Generalized mesh support for diffusion module #15

nury12n opened this issue Dec 11, 2024 · 0 comments

Comments

@nury12n
Copy link
Collaborator

nury12n commented Dec 11, 2024

The single phase diffusion and homogenization model both assume 1D cartesian coordinates. It would be nice to extend this feature to other coordinate systems (radial/cylindrical and spherical). In addition, extended to 2D or 3D meshes would work as well.

My preferred solution would be to have Mesh class, that each coordinate system will inherit (ex. CartesianMesh, SphericalMesh, 3DMesh). These objects will have the necessary implementations to compute fluxes, time interval and updating composition, while all the diffusion models have to output is a diffusivity or equivalent.

Example pseudocode of what I'm hoping for

thermo  = Thermodynamics(...)
mesh = RadialMesh(rlimits, nodes)
model = DiffusionModel(thermo, mesh, other parameters)
model.solve(time)
@nury12n nury12n mentioned this issue Dec 16, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant