Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better secrets handling with Pydantic 2 #507

Closed
Andrew-S-Rosen opened this issue Sep 3, 2023 · 1 comment
Closed

Better secrets handling with Pydantic 2 #507

Andrew-S-Rosen opened this issue Sep 3, 2023 · 1 comment

Comments

@Andrew-S-Rosen
Copy link
Member

Andrew-S-Rosen commented Sep 3, 2023

When we transition to Pydantic 2 (@munrojm is working on this for much of the MP stack), we should think about a slightly more secure mechanism for storing database secrets both in Jobflow configuration files. This is specifically referring to maggma-based credentials.

My proposed recommendation is to use the secrets management features of pydantic-settings, as discussed here (also see this page). Of course, there's no way of avoiding storing some credential somewhere, but this seems like a slightly better approach. That way, if someone shares their config file with someone else without thinking (or even posts it on GitHub), their credentials won't be directly exposed.

@Andrew-S-Rosen
Copy link
Member Author

Transitioned this to the Jobflow repo. materialsproject/jobflow#451

@Andrew-S-Rosen Andrew-S-Rosen closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant