Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .github repository to outline broad principles #13

Open
shyuep opened this issue Sep 5, 2023 · 4 comments
Open

Use .github repository to outline broad principles #13

shyuep opened this issue Sep 5, 2023 · 4 comments
Labels
dx Developer experience standardization Issues and PRs pertaining to standardization across MP repos

Comments

@shyuep
Copy link
Member

shyuep commented Sep 5, 2023

I have created the Materials Project .github repository. This allows one to write a standard set of files, e.g., PR templates, Issue templates, a profile page (check out the MP organizational Github page). I suggest you use this to standardize common practices across ALL MP's repos. I have added pymatgen's templates as a default. I will leave it to MP folks to figure this out. @janosh has been made an admin for that repo and he can add whoever else needs access.

@janosh janosh added dx Developer experience standardization Issues and PRs pertaining to standardization across MP repos labels Sep 8, 2023
@janosh
Copy link
Member

janosh commented Sep 8, 2023

Great idea, thanks @shyuep! @utf How about we bring this up in the next foundation meeting to discuss how exactly we want to standardize issue/PR templates across MP repos?

@janosh
Copy link
Member

janosh commented Sep 10, 2023

Let's keep an eye on https://github.com/orgs/community/discussions/7926. I just added .github/release.yml to pymatgen.

Would be nice to standardize release note format across MP repos.

See pymatgen v2023.9.10 for what such a format might look like.

@rkingsbury
Copy link
Collaborator

Sounds like a good idea! Harmonizing all the packaging minutia would really streamline repo maintenance for all of us busy PIs. Note that I've been using pyscaffold as a reference point for many things (similar idea, but more general). Will be great to have an MP-specific repo template.

@shyuep
Copy link
Member Author

shyuep commented Sep 11, 2023

The PR and Issue templates are completely standardized. This is a good thing because all of MP will ask for the same basic info when reporting bugs and feature requests.

The workflow templates in the .github repo are just templates. When someone sets up a new workflow in an MP repo, that template is then provided as an option to setup the workflow. Again, this is a good practice. It makes sure that all MP goes through the same basic steps for lining, testing, and release. Of course, it does nothing to enforce that tests are actually written or passes... that is up to the maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Developer experience standardization Issues and PRs pertaining to standardization across MP repos
Projects
None yet
Development

No branches or pull requests

3 participants