Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] add a check on split parameters values. #151

Closed
alessiovignoli opened this issue May 24, 2024 · 1 comment
Closed

[feat] add a check on split parameters values. #151

alessiovignoli opened this issue May 24, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@alessiovignoli
Copy link
Contributor

The split functions can work with a set of values like this -> [1.0, 0.0, 0.0]. basically the can handle a zero on a given set.
Problem is that an empty set fucks up the pipeline in terrible ways.

Easy solution: when the input experiment config is passed the values are read and if there is a 0 throw an error to the user.

@alessiovignoli alessiovignoli added enhancement New feature or request good first issue Good for newcomers labels May 24, 2024
@alessiovignoli alessiovignoli added this to the 1.0 - First clean release milestone May 24, 2024
@alessiovignoli alessiovignoli changed the title add a check on split parameters values. [feat] add a check on split parameters values. Jul 26, 2024
@mathysgrapotte mathysgrapotte removed this from the 1.0 - First clean release milestone Sep 12, 2024
@mathysgrapotte
Copy link
Contributor

cf stimulus-py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants