Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape control characters in log messages #22937

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Escape control characters in log messages #22937

merged 2 commits into from
Jan 17, 2025

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 16, 2025

Description:

Review

@sgiehl sgiehl added the Needs Review PRs that need a code review label Jan 16, 2025
@sgiehl sgiehl added this to the 5.3.0 milestone Jan 16, 2025
@sgiehl sgiehl requested a review from a team January 16, 2025 10:26
@michalkleiner
Copy link
Contributor

What problem does this fix, do you have an example before and after?

@michalkleiner
Copy link
Contributor

No worries, I've at the internal issue now.

@sgiehl sgiehl merged commit ff9070a into 5.x-dev Jan 17, 2025
22 of 26 checks passed
@sgiehl sgiehl deleted the dev-18839 branch January 17, 2025 12:51
sgiehl added a commit that referenced this pull request Jan 17, 2025
* Escape control characters in log messages

* Fix handling of line breaks
mneudert pushed a commit that referenced this pull request Jan 17, 2025
* Escape control characters in log messages

* Fix handling of line breaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants