Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build is failing #33

Open
palnabarun opened this issue Aug 21, 2018 · 4 comments
Open

Build is failing #33

palnabarun opened this issue Aug 21, 2018 · 4 comments
Assignees

Comments

@palnabarun
Copy link
Member

While working on the other PR, I saw that the master's Travis build is failing. On further investigations, I found that they were failing due to change in how Altair interpreted inline data. The earlier behavior was to keep Inline Data as it is, but now they convert it into Named Data. This was breaking our tests as we did not have support for that.

Ref:
Altair Changelog
Failing Travis Builds

@palnabarun
Copy link
Member Author

palnabarun commented Aug 21, 2018

I also suggest adding a Travis Build badge to the Readme so that we know if a build is failing.

@tacaswell
Copy link
Member

Adding using alt.data_transformers.consolidate_datasets = False is probably a good quick-fix.

How big of a change is it to adapt to the new scheme? It may be best to simply require altair 2.2.0+ and only support that.

@palnabarun
Copy link
Member Author

palnabarun commented Aug 21, 2018

I am okay with both the options, either specifying the consolidate_datasets flag or the project allows altair versions <= 2.1.0 .

However, since the support was needed at some point in time, I went ahead to put up a check for the availability of a named dataset. I pushed some modifications few minutes ago which checks if the dataset named is present or not.

One issue I am facing right now is testing the case when named data is specified but no dataset is passed on to altair.

@palnabarun
Copy link
Member Author

Figured out the test case. Please have a look at the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants