Adds support for named data #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the current build errors due to a change in how Altair interprets inline data. More information on y#33
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
===========================================
+ Coverage 62.81% 99.66% +36.84%
===========================================
Files 13 13
Lines 589 599 +10
Branches 62 64 +2
===========================================
+ Hits 370 597 +227
+ Misses 218 1 -217
Partials 1 1
Continue to review full report at Codecov.
|
samuelsinayoko
approved these changes
Dec 2, 2020
samuelsinayoko
suggested changes
Dec 2, 2020
There was a problem hiding this comment.
Needs updating for matplotlib 3.3
FAILED mplaltair/tests/test_axis.py::test_invalid_temporal - AttributeError: module 'matplotlib.cbook' has no attribute 'iterable'
FAILED mplaltair/tests/test_axis.py::test_axis[df2-months-years] - AttributeError: module 'matplotlib.cbook' has no attribute 'iterable'
FAILED mplaltair/tests/test_axis.py::test_axis[df3-years-months] - AttributeError: module 'matplotlib.cbook' has no attribute 'iterable'
FAILED mplaltair/tests/test_axis.py::test_axis[df4-months-combination] - AttributeError: module 'matplotlib.cbook' has no attribute 'iterable'
FAILED mplaltair/tests/test_axis.py::test_axis_domain[df2-days-hrs-x_dom2-y_dom2] - AttributeError: module 'matplotlib.cbook' has no attribu...
FAILED mplaltair/tests/test_axis.py::test_axis_domain[df3-a-days-x_dom3-y_dom3] - AttributeError: module 'matplotlib.cbook' has no attribute...
FAILED mplaltair/tests/test_axis.py::test_axis_values[df1-months-vals1] - AttributeError: module 'matplotlib.cbook' has no attribute 'iterable'
FAILED mplaltair/tests/test_axis.py::test_axis_tickCount[df3-years-1] - AttributeError: module 'matplotlib.cbook' has no attribute 'iterable'
FAILED mplaltair/tests/test_axis.py::test_axis_tickCount[df4-years-4] - AttributeError: module 'matplotlib.cbook' has no attribute 'iterable'
FAILED mplaltair/tests/test_axis.py::test_axis_tickCount[df5-years-9] - AttributeError: module 'matplotlib.cbook' has no attribute 'iterable'
FAILED mplaltair/tests/test_axis.py::test_axis_tickCount[df6-hrs-1] - AttributeError: module 'matplotlib.cbook' has no attribute 'iterable'
FAILED mplaltair/tests/test_axis.py::test_axis_tickCount[df7-hrs-4] - AttributeError: module 'matplotlib.cbook' has no attribute 'iterable'
FAILED mplaltair/tests/test_axis.py::test_axis_tickCount[df8-hrs-9] - AttributeError: module 'matplotlib.cbook' has no attribute 'iterable'
FAILED mplaltair/tests/test_axis.py::test_axis_tickCount[df9-combination-1] - AttributeError: module 'matplotlib.cbook' has no attribute 'it...
FAILED mplaltair/tests/test_axis.py::test_axis_tickCount[df10-combination-4] - AttributeError: module 'matplotlib.cbook' has no attribute 'i...
FAILED mplaltair/tests/test_axis.py::test_axis_tickCount[df11-combination-9] - AttributeError: module 'matplotlib.cbook' has no attribute 'i...
FAILED mplaltair/tests/test_axis.py::test_axis_scale_basic[df1-years-time] - AttributeError: module 'matplotlib.cbook' has no attribute 'ite...
FAILED mplaltair/tests/test_axis.py::test_axis_scale_NotImplemented_quantitative[df2-months-utc] - AttributeError: module 'matplotlib.cbook'...
FAILED mplaltair/tests/test_axis.py::test_axis_formatter_temporal - AttributeError: module 'matplotlib.cbook' has no attribute 'iterable'
FAILED mplaltair/tests/test_convert.py::test_invalid_encodings - NotImplementedError
FAILED mplaltair/tests/test_convert.py::test_invalid_temporal - AttributeError: module 'matplotlib.cbook' has no attribute 'iterable'
FAILED mplaltair/tests/test_convert.py::test_convert_x_success_temporal[years] - AttributeError: module 'matplotlib.cbook' has no attribute ...
FAILED mplaltair/tests/test_convert.py::test_convert_x_success_temporal[months] - AttributeError: module 'matplotlib.cbook' has no attribute...
FAILED mplaltair/tests/test_convert.py::test_convert_x_success_temporal[days] - AttributeError: module 'matplotlib.cbook' has no attribute '...
FAILED mplaltair/tests/test_convert.py::test_convert_x_success_temporal[hrs] - AttributeError: module 'matplotlib.cbook' has no attribute 'i...
FAILED mplaltair/tests/test_convert.py::test_convert_x_success_temporal[combination] - AttributeError: module 'matplotlib.cbook' has no attr...
FAILED mplaltair/tests/test_convert.py::test_convert_y_success_temporal[years] - AttributeError: module 'matplotlib.cbook' has no attribute ...
FAILED mplaltair/tests/test_convert.py::test_convert_y_success_temporal[months] - AttributeError: module 'matplotlib.cbook' has no attribute...
FAILED mplaltair/tests/test_convert.py::test_convert_y_success_temporal[days] - AttributeError: module 'matplotlib.cbook' has no attribute '...
FAILED mplaltair/tests/test_convert.py::test_convert_y_success_temporal[hrs] - AttributeError: module 'matplotlib.cbook' has no attribute 'i...
FAILED mplaltair/tests/test_convert.py::test_convert_y_success_temporal[combination] - AttributeError: module 'matplotlib.cbook' has no attr...
FAILED mplaltair/tests/test_convert.py::test_quantitative_x2_y2 - NotImplementedError
FAILED mplaltair/tests/test_convert.py::test_convert_x2_y2_fail_temporal[years] - NotImplementedError
FAILED mplaltair/tests/test_convert.py::test_convert_x2_y2_fail_temporal[months] - NotImplementedError
FAILED mplaltair/tests/test_convert.py::test_convert_x2_y2_fail_temporal[days] - NotImplementedError
FAILED mplaltair/tests/test_convert.py::test_convert_x2_y2_fail_temporal[hrs] - NotImplementedError
FAILED mplaltair/tests/test_convert.py::test_convert_x2_y2_fail_temporal[combination] - NotImplementedError
FAILED mplaltair/tests/test_convert.py::test_convert_color_success_temporal[years] - AttributeError: module 'matplotlib.cbook' has no attrib...
FAILED mplaltair/tests/test_convert.py::test_convert_color_success_temporal[months] - AttributeError: module 'matplotlib.cbook' has no attri...
FAILED mplaltair/tests/test_convert.py::test_convert_color_success_temporal[days] - AttributeError: module 'matplotlib.cbook' has no attribu...
FAILED mplaltair/tests/test_convert.py::test_convert_color_success_temporal[hrs] - AttributeError: module 'matplotlib.cbook' has no attribut...
FAILED mplaltair/tests/test_convert.py::test_convert_color_success_temporal[combination] - AttributeError: module 'matplotlib.cbook' has no ...
FAILED mplaltair/tests/test_convert.py::test_convert_fill_success_temporal[years] - AttributeError: module 'matplotlib.cbook' has no attribu...
FAILED mplaltair/tests/test_convert.py::test_convert_fill_success_temporal[months] - AttributeError: module 'matplotlib.cbook' has no attrib...
FAILED mplaltair/tests/test_convert.py::test_convert_fill_success_temporal[days] - AttributeError: module 'matplotlib.cbook' has no attribut...
FAILED mplaltair/tests/test_convert.py::test_convert_fill_success_temporal[hrs] - AttributeError: module 'matplotlib.cbook' has no attribute...
FAILED mplaltair/tests/test_convert.py::test_convert_fill_success_temporal[combination] - AttributeError: module 'matplotlib.cbook' has no a...
FAILED mplaltair/tests/test_convert.py::test_quantitative_shape - altair.utils.schemapi.SchemaValidationError: Invalid specification
FAILED mplaltair/tests/test_convert.py::test_convert_shape_fail_temporal[years] - altair.utils.schemapi.SchemaValidationError: Invalid speci...
FAILED mplaltair/tests/test_convert.py::test_convert_shape_fail_temporal[months] - altair.utils.schemapi.SchemaValidationError: Invalid spec...
FAILED mplaltair/tests/test_convert.py::test_convert_shape_fail_temporal[days] - altair.utils.schemapi.SchemaValidationError: Invalid specif...
FAILED mplaltair/tests/test_convert.py::test_convert_shape_fail_temporal[hrs] - altair.utils.schemapi.SchemaValidationError: Invalid specifi...
FAILED mplaltair/tests/test_convert.py::test_convert_shape_fail_temporal[combination] - altair.utils.schemapi.SchemaValidationError: Invalid...
FAILED mplaltair/tests/test_convert.py::test_convert_opacity_fail_temporal[years] - AttributeError: module 'matplotlib.cbook' has no attribu...
FAILED mplaltair/tests/test_convert.py::test_convert_opacity_fail_temporal[months] - AttributeError: module 'matplotlib.cbook' has no attrib...
FAILED mplaltair/tests/test_convert.py::test_convert_opacity_fail_temporal[days] - AttributeError: module 'matplotlib.cbook' has no attribut...
FAILED mplaltair/tests/test_convert.py::test_convert_opacity_fail_temporal[hrs] - AttributeError: module 'matplotlib.cbook' has no attribute...
FAILED mplaltair/tests/test_convert.py::test_convert_opacity_fail_temporal[combination] - AttributeError: module 'matplotlib.cbook' has no a...
FAILED mplaltair/tests/test_convert.py::test_convert_size_fail_temporal[years] - AttributeError: module 'matplotlib.cbook' has no attribute ...
FAILED mplaltair/tests/test_convert.py::test_convert_size_fail_temporal[months] - AttributeError: module 'matplotlib.cbook' has no attribute...
FAILED mplaltair/tests/test_convert.py::test_convert_size_fail_temporal[days] - AttributeError: module 'matplotlib.cbook' has no attribute '...
FAILED mplaltair/tests/test_convert.py::test_convert_size_fail_temporal[hrs] - AttributeError: module 'matplotlib.cbook' has no attribute 'i...
FAILED mplaltair/tests/test_convert.py::test_convert_size_fail_temporal[combination] - AttributeError: module 'matplotlib.cbook' has no attr...
FAILED mplaltair/tests/test_convert.py::test_convert_stroke_fail_temporal[years] - AttributeError: module 'matplotlib.cbook' has no attribut...
FAILED mplaltair/tests/test_convert.py::test_convert_stroke_fail_temporal[months] - AttributeError: module 'matplotlib.cbook' has no attribu...
FAILED mplaltair/tests/test_convert.py::test_convert_stroke_fail_temporal[days] - AttributeError: module 'matplotlib.cbook' has no attribute...
FAILED mplaltair/tests/test_convert.py::test_convert_stroke_fail_temporal[hrs] - AttributeError: module 'matplotlib.cbook' has no attribute ...
FAILED mplaltair/tests/test_convert.py::test_convert_stroke_fail_temporal[combination] - AttributeError: module 'matplotlib.cbook' has no at...
FAILED mplaltair/tests/test_convert.py::test_scatter_temporal[channel0] - AttributeError: module 'matplotlib.cbook' has no attribute 'iterable'
FAILED mplaltair/tests/test_convert.py::test_scatter_temporal[channel1] - AttributeError: module 'matplotlib.cbook' has no attribute 'iterable'
FAILED mplaltair/tests/test_convert.py::TestLines::test_line_opacity[dates:T] - AttributeError: module 'matplotlib.cbook' has no attribute '...
FAILED mplaltair/tests/test_convert.py::TestLines::test_line_opacity_color[dates:T-dates:T] - AttributeError: module 'matplotlib.cbook' has ...
FAILED mplaltair/tests/test_data.py::test_convert_to_mpl_str - AttributeError: module 'matplotlib.cbook' has no attribute 'iterable'
FAILED mplaltair/tests/test_data.py::test_convert_to_mpl_datetime64 - AttributeError: module 'matplotlib.cbook' has no attribute 'iterable'
FAILED mplaltair/tests/test_data.py::test_convert_to_mpl_altair_datetime - AttributeError: module 'matplotlib.cbook' has no attribute 'itera...
FAILED mplaltair/tests/test_data.py::test_convert_to_mpl_empty - AttributeError: module 'matplotlib.cbook' has no attribute 'iterable'
FAILED mplaltair/tests/test_data.py::test_convert_to_mpl_single_vals[2015-03-07 12:32:17-16501.52241898148] - AttributeError: module 'matplo...
FAILED mplaltair/tests/test_data.py::test_convert_to_mpl_single_vals[date1-16804.416666666668] - AttributeError: module 'matplotlib.cbook' h...
FAILED mplaltair/tests/test_data.py::test_convert_to_mpl_single_vals[date2-16501.0] - AttributeError: module 'matplotlib.cbook' has no attri...
FAILED mplaltair/tests/test_parse_chart.py::test_data_field_quantitative[combination-temporal] - AttributeError: module 'matplotlib.cbook' h...
FAILED mplaltair/tests/test_parse_chart.py::test_data_shorthand_quantitative[combination] - AttributeError: module 'matplotlib.cbook' has no...
FAILED mplaltair/tests/test_parse_chart.py::test_data_dtype[combination:T-temporal] - AttributeError: module 'matplotlib.cbook' has no attri...
=========================================== 82 failed, 76 passed, 19 xfailed, 5 warnings in 28.47s ============================================
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the current build errors due to a change in how Altair
interprets inline data. More information on #33