From a03893ee3fd74d1d99f46acd1543aa10633a7e13 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Damir=20Jeli=C4=87?= <poljar@termina.org.uk>
Date: Thu, 8 Aug 2024 12:58:51 +0200
Subject: [PATCH] ci: Enable CI for draft PRs (#3815)

Our CI used to be quite slow and used up a lot of CI time, so as an
optimization we disabled CI for draft PRs.

This is a bit annoying since people want to open draft PRs to check if
CI passes, but without triggering any review requests.

Since our CI is nowadays a bit more efficient let's see if we can enable
it for draft PRs.
---
 .github/workflows/benchmarks.yml      | 2 +-
 .github/workflows/ci.yml              | 9 ---------
 .github/workflows/coverage.yml        | 1 -
 .github/workflows/documentation.yml   | 1 -
 .github/workflows/upload_coverage.yml | 2 +-
 .github/workflows/xtask.yml           | 2 +-
 6 files changed, 3 insertions(+), 14 deletions(-)

diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml
index 873c6065b32..9f6f4e6e2a4 100644
--- a/.github/workflows/benchmarks.yml
+++ b/.github/workflows/benchmarks.yml
@@ -8,7 +8,7 @@ jobs:
     name: Run Benchmarks
     runs-on: ubuntu-latest
     environment: matrix-rust-bot
-    if: github.event_name == 'push' || !github.event.pull_request.draft
+    if: github.event_name == 'push'
 
     steps:
     - name: Checkout the repo
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 83a56c7bcc8..82666e8e113 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -26,7 +26,6 @@ jobs:
   test-matrix-sdk-features:
     name: 🐧 [m], ${{ matrix.name }}
     needs: xtask
-    if: github.event_name == 'push' || !github.event.pull_request.draft
 
     runs-on: ubuntu-latest
     strategy:
@@ -79,7 +78,6 @@ jobs:
     name: 🐧 [m]-examples
     needs: xtask
     runs-on: ubuntu-latest
-    if: github.event_name == 'push' || !github.event.pull_request.draft
 
     steps:
       - name: Checkout the repo
@@ -111,7 +109,6 @@ jobs:
     name: 🐧 [m]-crypto
     needs: xtask
     runs-on: ubuntu-latest
-    if: github.event_name == 'push' || !github.event.pull_request.draft
 
     steps:
       - name: Checkout the repo
@@ -141,7 +138,6 @@ jobs:
 
   test-all-crates:
     name: ${{ matrix.name }}
-    if: github.event_name == 'push' || !github.event.pull_request.draft
 
     runs-on: ${{ matrix.os }}
     strategy:
@@ -194,7 +190,6 @@ jobs:
   test-wasm:
     name: 🕸️ ${{ matrix.name }}
     needs: xtask
-    if: github.event_name == 'push' || !github.event.pull_request.draft
 
     runs-on: ubuntu-latest
 
@@ -270,7 +265,6 @@ jobs:
   formatting:
     name: Check Formatting
     runs-on: ubuntu-latest
-    if: github.event_name == 'push' || !github.event.pull_request.draft
 
     steps:
       - name: Checkout the repo
@@ -289,7 +283,6 @@ jobs:
   typos:
     name: Spell Check with Typos
     runs-on: ubuntu-latest
-    if: github.event_name == 'push' || !github.event.pull_request.draft
 
     steps:
       - name: Checkout Actions Repository
@@ -302,7 +295,6 @@ jobs:
     name: Run clippy
     needs: xtask
     runs-on: ubuntu-latest
-    if: github.event_name == 'push' || !github.event.pull_request.draft
 
     steps:
       - name: Checkout the repo
@@ -337,7 +329,6 @@ jobs:
 
   integration-tests:
     name: Integration test
-    if: github.event_name == 'push' || !github.event.pull_request.draft
 
     runs-on: ubuntu-latest
 
diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml
index c5688ec25cd..d0f04243867 100644
--- a/.github/workflows/coverage.yml
+++ b/.github/workflows/coverage.yml
@@ -25,7 +25,6 @@ jobs:
   code_coverage:
     name: Code Coverage
     runs-on: "ubuntu-latest"
-    if: github.event_name == 'push' || !github.event.pull_request.draft
 
     # run several docker containers with the same networking stack so the hostname 'postgres'
     # maps to the postgres container, etc.
diff --git a/.github/workflows/documentation.yml b/.github/workflows/documentation.yml
index e5403a5b88a..a9ebd1dcd4b 100644
--- a/.github/workflows/documentation.yml
+++ b/.github/workflows/documentation.yml
@@ -23,7 +23,6 @@ jobs:
   docs:
     name: All crates
     runs-on: ubuntu-latest
-    if: github.event_name == 'push' || !github.event.pull_request.draft
 
     steps:
       - name: Checkout repository
diff --git a/.github/workflows/upload_coverage.yml b/.github/workflows/upload_coverage.yml
index da1447341f7..eda15459eed 100644
--- a/.github/workflows/upload_coverage.yml
+++ b/.github/workflows/upload_coverage.yml
@@ -3,7 +3,7 @@
 name: Codecov
 
 on:
-  # This workflow is triggered after every successfull execution
+  # This workflow is triggered after every successful execution
   # of `coverage` workflow.
   workflow_run:
     workflows: ["Code Coverage"]
diff --git a/.github/workflows/xtask.yml b/.github/workflows/xtask.yml
index 901bccd9667..f359c20a274 100644
--- a/.github/workflows/xtask.yml
+++ b/.github/workflows/xtask.yml
@@ -57,7 +57,7 @@ jobs:
         id: xtask-cache
         with:
           path: target/debug/xtask
-          # use the cache key calculated in the step above. Bit of an awkard
+          # use the cache key calculated in the step above. Bit of an awkward
           # syntax
           key: |
             ${{ steps.cachekey.outputs[format('cachekey-{0}', matrix.cachekey-id)] }}