Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename (LSP)Shipment? #45

Open
1 of 4 tasks
kt86 opened this issue Sep 19, 2022 · 1 comment
Open
1 of 4 tasks

Rename (LSP)Shipment? #45

kt86 opened this issue Sep 19, 2022 · 1 comment
Labels
enhancement New feature or request withKN Something where I need some input from KN

Comments

@kt86
Copy link
Contributor

kt86 commented Sep 19, 2022

It is very confusing for me, because we have a lot of usage of LSPShipments, but in freight there are existing the CarrierShipments

In many steps, e.g. in the ScheduledShipmentLoad, ScheduledShipmentHandle, ScheduledShipmentUnload, a Carrier_Service_ is added .... (which is neither a LSPShipment not a CarrierShipment.

If we decide in the future to also use CarrierShipments (see #44), the confusion is perfect :(

Maybe try in a first step to name everything that is related to an LSPShipment with lspShipment (instead of just shipment) ?? (Or do we already have a better idea? --> "job", "order", ... ?

(Update 24.11.2022)

  • Rename all shipments entsprechend ihres Types -> lspShipment, carrierShipment
  • Prüfe Datenstuktur von LSPShipment und CarrierShipment und wie man die zur Deckung bringen könnte, ggf. mit Attributen.
  • Diskussion und Entscheidung mit KN: Führen wir das zusammen oder sagen wir, dass der LSP "Aufträge" / "Jobs" bekommt und die Shipments dann das sind, was zwischen den Carriern rumgereicht wird - da sind ja u.U interne Zeitfenster anders.
  • Umsetzung dessen
@kt86
Copy link
Contributor Author

kt86 commented Nov 24, 2022

After discussion witth KN:

Let's check, if we there is enough overlap between LSPShipment and CarrierShipment so we can condense it to just one type of Shipments.

If some fields are missing, we can use Attributes for it.

@kt86 kt86 added this to the cleanup Dec22 milestone Nov 24, 2022
@kt86 kt86 added enhancement New feature or request withKN Something where I need some input from KN labels Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request withKN Something where I need some input from KN
Projects
None yet
Development

No branches or pull requests

1 participant