Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ShipmentLog #50

Open
1 of 7 tasks
kt86 opened this issue Oct 18, 2022 · 2 comments
Open
1 of 7 tasks

remove ShipmentLog #50

kt86 opened this issue Oct 18, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@kt86
Copy link
Contributor

kt86 commented Oct 18, 2022

Die (LSP) Shipments haben derzeit neben ihrem Schedule auch einen eigenen Log. Dieser soll darstellen, was tatsächlich passiert.

Mit zunehmender Nutzung der MATSim-Event Infrastruktur ist dann die Frage, ob nicht diese die Grundlage für alles Weitere seien sollte und nicht so ein "zwischendurch" irgendwie erstelltes Log.
Das würde auch die Anzahl der Objekte deutlich reduzieren, die dafür dann nochmal als Teil-Dubletten angelegt werden...

Das impliziert dann auch, dass die entsprechenden Tests umgebaut werden auf Events-Vergleich -> MATSimTestUtils.compareEventsFile(...)

(Update 24.11.2022 KMT)

  • Alle dies betreffenden Tests erweitern um Events-Vergleich
  • Handling in Hubs noch in Events einbauen (add Events for handling of shipments in hubs #48)
  • Update der Test-input Events-Dateien
  • Test gegen ShipmentLogs entfernen
  • dabei eventuell ein paar inhaltliche Checks in Assertion beibehalten?
  • ShipmentLog entfernen
  • Schauen, was dann in den EventHandler alles an Infrastruktur entfernt werden kann.
@kt86 kt86 added the enhancement New feature or request label Oct 18, 2022
@kt86
Copy link
Contributor Author

kt86 commented Nov 24, 2022

After discussion with KN: We will remove that Shipment logs soon.

@kt86 kt86 changed the title remove ShipmentLog? remove ShipmentLog Nov 24, 2022
@kt86 kt86 added this to the cleanup Dec22 milestone Nov 24, 2022
@kt86
Copy link
Contributor Author

kt86 commented Nov 20, 2023

Had another discussion with KN: We will tread that log somehow as an experienced plan of the shipment.
So it is ok, that it remains.

Will check if we can improve some names, to clarify this.
Moreover, there will be some cleanup / follow-up work to e.g, to separate this “logging” from the productive code a bit. One first idea is to move as much as possible an own class, which will do all the logging in one place instead of having it spread all over the places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant