Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line expansion index array too big #4

Open
Scarysize opened this issue Jan 25, 2017 · 1 comment
Open

Line expansion index array too big #4

Scarysize opened this issue Jan 25, 2017 · 1 comment

Comments

@Scarysize
Copy link

Hey, just went through your code, because I wanted to recreate the line width via expansion and I noticed that the index array your are generating in gl-line-2d is too big.

You create it via

indices = createIndices(path.length);

(https://github.com/mattdesl/webgl-lines/blob/master/expanded/gl-line-2d.js#L50)

But path.length - 1 should probably be enough.

Thanks for the great article and the code shared! 👍

@metamic
Copy link

metamic commented Sep 28, 2020

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants