Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor hardhat_, evm_, and zks_ namespace implementations #170

Closed
nbaztec opened this issue Oct 11, 2023 · 0 comments · Fixed by #197
Closed

Refactor hardhat_, evm_, and zks_ namespace implementations #170

nbaztec opened this issue Oct 11, 2023 · 0 comments · Fixed by #197
Labels
approved ✅ PR is ready to be merged feature ➕ Feature item medium 🚩 Indicates moderately difficult item p1 🟠 Indicates high priority item

Comments

@nbaztec
Copy link
Contributor

nbaztec commented Oct 11, 2023

📝 Description

Refactor the hardhat_, evm_, and zks_ namespace implementations for some functions to be stored in a centralized location, so they can be re-used accordingly.

For example, the following endpoints are doing the same thing:

  • evm_setAccountNonce
  • hardhat_setNonce
  • anvil_setNonce

🤔 Rationale

Centralizing namespaces would lead to a significantly lower effort for contributors implementing other namespaces and/or methods.

📋 Additional Context

This is a prerequisite for #160

@MexicanAce MexicanAce added approved ✅ PR is ready to be merged p1 🟠 Indicates high priority item medium 🚩 Indicates moderately difficult item feature ➕ Feature item labels Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ✅ PR is ready to be merged feature ➕ Feature item medium 🚩 Indicates moderately difficult item p1 🟠 Indicates high priority item
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants