Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for cross-site passkey domain #158

Open
cpb8010 opened this issue Nov 12, 2024 · 0 comments
Open

Add validation for cross-site passkey domain #158

cpb8010 opened this issue Nov 12, 2024 · 0 comments
Labels
project: contracts question Further information is requested

Comments

@cpb8010
Copy link
Contributor

cpb8010 commented Nov 12, 2024

There's a field in the passkey that indicates if it was created via cross-site request (which may be required for sites that have an API on a different domain than the site is hosted on). https://web.dev/articles/webauthn-related-origin-requests

It's not clear that we have a use case to support this as our passkey request always comes from the same domain, but it's possible that some embedded wallets are hosted across multiple domains and would want to make use of this?

It's not clear if we should explicitly forbid this in an attempt to prevent people from abusing this, or if we should implicitly allow it in hopes that someone can use this productively.

@cpb8010 cpb8010 added question Further information is requested project: contracts labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project: contracts question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant