Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mattermost Reorganizes json #38

Open
ewwollesen opened this issue Mar 27, 2020 · 2 comments
Open

Mattermost Reorganizes json #38

ewwollesen opened this issue Mar 27, 2020 · 2 comments
Labels
Difficulty/2:Medium Medium ticket Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Bug Something isn't working Up For Grabs Ready for help from the community. Removed when someone volunteers

Comments

@ewwollesen
Copy link

So I will say at first that I admit this is probably not a big deal in the grand scheme of things, and maybe is as much a personal preference issue as anything. The issue is that when you load the config into the Mattermost config.json file, it reorganizes the layout and makes it (in my opinion) more difficult to follow and easier to make a mistake if you need to update it.

What I'm talking about is if you look at the example in the readme, it's pretty easy to follow what's going on. The TeamName is at the top, followed by the Message and so on...

"WelcomeMessages": [
            {
                "TeamName": "your-team-name",
                "DelayInSeconds": 3,
                "Message": [
                    "Your welcome message here. Each list item specifies one line in the message text."
                ],
                "AttachmentMessage": [
                    "Attachment message containing user actions"
                ],
                "Actions" : [
                    {

The problem is that when you start Mattermost, it rearranges everything in to alphabetical order and makes it harder to follow.

"com.mattermost.welcomebot": {
                "welcomemessages": [
                    {
                        "Actions": [
                            {
                                "ActionDisplayName": "I'm a Developer",
                                "ActionName": "developer-action",
                                "ActionSuccessfulMessage": [
                                                                    ],
                                "ActionType": "button",
                                "ChannelsAddedTo": [
                                                      ]
                            },
                            {
                                "ActionDisplayName": "Change and Incident Management",
                                "ActionName": "manager-action",
                                "ActionSuccessfulMessage": [
                                ],
                                "ActionType": "button",
                                "ChannelsAddedTo": [
                                                                  ]
                            },
                            {
                                "ActionType": "automatic",
                                "ChannelsAddedTo": [
                                                                  ]
                            }
                        ],
                        "AttachmentMessage": [
                            "I can help you get started by joining you to some existing channels. Which types of channels would you like to join?"
                        ],
                        "DelayInSeconds": 5,
                        "Message": [
                            "### Welcome to Mattermost!",
],
                        "TeamName": "team"

I cut a lot of stuff out obviously, but hopefully you can see what I'm talking about with the TeamName being at the bottom, and some of the fields being kind of all over the place. Is this something that can be fixed so it doesn't do this?

Again, I admit that this is maybe just my personal preference as much as an actual issue that needs to be addressed and I don't like Mattermost messing with my config.json in general, but I thought it was worth pointing out at least.

@levb
Copy link
Contributor

levb commented Apr 7, 2020

@ewwollesen is it happening every time, or if you configure the plugin with a / command?

@levb levb added Triage Type/Bug Something isn't working labels Apr 7, 2020
@ewwollesen
Copy link
Author

@ewwollesen is it happening every time, or if you configure the plugin with a / command?

I happens whenever I start up Mattermost. I do all my configuration in the config.json file, and then when I start up Mattermost is when it rearranges everything.

@aaronrothschild aaronrothschild self-assigned this Apr 14, 2020
@levb levb assigned levb and unassigned aaronrothschild Apr 21, 2020
@levb levb added Difficulty/2:Medium Medium ticket Help Wanted Community help wanted Tech/Go Up For Grabs Ready for help from the community. Removed when someone volunteers and removed Triage labels Apr 21, 2020
@hanzei hanzei unassigned levb Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/2:Medium Medium ticket Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Bug Something isn't working Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet
Development

No branches or pull requests

5 participants