Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward and previous channel button does not change application title #1563

Open
3 tasks done
Dartui opened this issue Apr 22, 2021 · 11 comments
Open
3 tasks done

Forward and previous channel button does not change application title #1563

Dartui opened this issue Apr 22, 2021 · 11 comments

Comments

@Dartui
Copy link

Dartui commented Apr 22, 2021

I confirm (by marking "x" in the [ ] below: [x]):


Summary

obraz

After clicking forward and previous channel buttons, application title does not change and stays the same.

Environment

  • Operating System: Xubuntu 18.04 / Windows 10
  • Mattermost Desktop App version: 4.6.2 (Xubuntu) / 4.6.1 (Windows)
  • Mattermost Server version: 5.34.2

Steps to reproduce

  1. Go on Channel 1 - application title changes to Channel 1
  2. Go on Channel 2 - application title changes to Channel 2
  3. Use Previous Channel button - channel is changed to Channel 1, but title says Channel 2

Expected behavior

Title changing with channel change

Observed behavior

Possible fixes

@amyblais
Copy link
Member

@Dartui Are you able to reproduce the same on v4.7-rc2 https://github.com/mattermost/desktop/releases?

@Dartui
Copy link
Author

Dartui commented Apr 23, 2021

@amyblais on Xubuntu, Mattermost 4.7-rc2 does not show channel name in application title at all. There is only "Mattermost Desktop App" in title. Later I will try it on Windows installation.

obraz

@Dartui
Copy link
Author

Dartui commented Apr 24, 2021

Windows installation has the same application title, no matter of which channel is selected - Mattermost Desktop App.

To be honest I kinda liked seeing what channel I had open, but displaying same title all the time is fixing this issue.

@datn
Copy link

datn commented Jul 5, 2021

Linux application also always displays "Mattermost Desktop App", which is way too long for my task manager and ends up hiding notification numbers. Would appreciate a configurable dynamic title --

@amyblais
Copy link
Member

amyblais commented Jul 6, 2021

cc @Willyfrog

@Willyfrog
Copy link
Contributor

Willyfrog commented Jul 7, 2021

we removed using the title from the webapp in 4.7, in 5.0 it will be replaced by something more sensible and useful based on the state of the app.

Linux application also always displays "Mattermost Desktop App", which is way too long for my task manager and ends up hiding notification numbers. Would appreciate a configurable dynamic title --

Can you provide a screenshot? from your description looks more like a WM issue rather than an app issue, but I would like to confirm.

@datn
Copy link

datn commented Jul 7, 2021

we removed using the title from the webapp in 4.7, in 5.0 it will be replaced by something more sensible and useful based on the state of the app.

Good to know, thanks.

Can you provide a screenshot? from your description looks more like a WM issue rather than an app issue, but I would like to confirm.

I can't currently, because for my sanity, I actually used a binary editor to modify the app.asar fle to change <title>Mattermost Desktop App</title> to <title>Mattermost</title>. (Then I added an HTML comment to soak up the spaces)

I hope this suffices:

#old 
0031F470  3A 22 3E 0A 20 20 20 20 3C 74 69 74 6C 65 3E 4D 61 74 74 65 72 6D 6F 73 :">.    <title>Mattermos
0031F488  74 20 44 65 73 6B 74 6F 70 20 41 70 70 3C 2F 74 69 74 6C 65 3E 0A 20 20 t Desktop App</title>.

#new
0031F470  3A 22 3E 0A 20 20 20 20 3C 74 69 74 6C 65 3E 6D 61 74 74 65 72 6D 6F 73 :">.    <title>mattermos
0031F488  74 3C 2F 74 69 74 6C 65 3E 20 20 3C 21 2D 2D 20 20 20 20 20 2D 2D 3E 20 t</title>  <!--     -->

@devinbinnie
Copy link
Member

@datn What sort of information would you like to see in the title going forward?

@datn
Copy link

datn commented Dec 10, 2021

Thanks for this. Ideally a customizable title, but mainly this: a title should be as short as possible while distinguishing itself from others. I already know it's an app, and I don't need the desktop app distinguished from the mobile app because they run on separate platforms. So "Mattermost" is all that's needed.

@devinbinnie
Copy link
Member

cc @esethna

@esethna
Copy link
Contributor

esethna commented Dec 13, 2021

@datn makes sense. Are you open to submitting a PR to shorten the title to "Mattermost" instead of "Mattermost Desktop App"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants