Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Screen sharing needs multiple confirmations #2817

Open
6 tasks done
apollo13 opened this issue Sep 2, 2023 · 7 comments
Open
6 tasks done

[Bug]: Screen sharing needs multiple confirmations #2817

apollo13 opened this issue Sep 2, 2023 · 7 comments

Comments

@apollo13
Copy link
Contributor

apollo13 commented Sep 2, 2023

Before you file a bug report

Mattermost Desktop Version

Version 5.5.0-rc.1 commit: f7b3a64

Operating System

Fedora 38

Mattermost Server Version

7.10.2

Steps to reproduce

  • Start a call
  • Click the screen sharing icon
  • Choose a screen/window via the portal and confirm (screenshot 1 below)
  • Get another confirmation dialog from mattermost for the shared window (screenshot 2 below)

Screenshot from 2023-09-02 13-11-43
Screenshot from 2023-09-02 13-11-32

Expected behavior

The second sharing screen (the white one from mattermost) should not show up. It doesn't show up when accessing the app in a browser directly, there it only shows the first dialog.

Observed behavior

After selecting the window to share, mattermost desktop shows yet another custom sharing dialog.

Log Output

Additional Information

No response

@streamer45
Copy link
Contributor

I assume this is the result of updating Electron. The screen permissions flow may need a review however this should only happen on Wayland setups which are likely not 100% supported.

@apollo13
Copy link
Contributor Author

apollo13 commented Sep 4, 2023

Yes this is only on wayland and it at least is finally in a state where it is usable and only an UX issue. Since wayland is the default on at least Fedora and Ubuntu nowadays it would probably make sense to support it explicitly instead of focusing on X11 as primary target.

@streamer45
Copy link
Contributor

Agreed. When I am talking about support I really mean from the Electron side. There's only so much we can do on this one. Now that the update happened we can plan ways to make it feel a bit more native from the application.

@apollo13
Copy link
Contributor Author

apollo13 commented Sep 4, 2023

From what I can gather the electron side of things is finally good! Before it crashed #2694 ;) But I just realized that I am in the wrong repo with this report as that might be fixable solely in the mattermost calls plugin.

@streamer45
Copy link
Contributor

That's good to know. I haven't looked in this yet but I think we'd need changes on this side as well because at the very least we need to understand what system we are on since this issue only exists on Wayland as far as I can tell.

@devinbinnie
Copy link
Member

@streamer45 Any progress on this? I seem to recall Electron having a fix for this but I don't really remember.

@streamer45
Copy link
Contributor

I think we are still stuck at electron/electron#37524 although I haven't really had a chance to test on Wayland still to see if there could be workarounds. Our internal ticket is https://mattermost.atlassian.net/browse/MM-53522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants