Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Downloading an SVG leads to error "Failed to get thumbnail from local thumbnail cache reference" #3140

Open
6 tasks done
bjoernmartin opened this issue Sep 3, 2024 · 15 comments

Comments

@bjoernmartin
Copy link

bjoernmartin commented Sep 3, 2024

Checks before filing an issue

Mattermost Desktop Version

5.9.0

Operating System

Windows 11 x64

Mattermost Server Version

EE 9.5.6

Steps to reproduce

  • Navigate to a chat with SVG images attached
  • Click on the Download icon of that SVG image

image

Expected behavior

  • SVG is successfully downloaded
  • No error message is shown and Mattermost does not need to restart

Observed behavior

  • SVG is successfully downloaded (yes, actual download works)
  • An error message is shown (see below) and Mattermost has to be restarted

image

Log Output

Application: Mattermost 5.9.0
Platform: Windows_NT 10.0.22631 x64
Error: Failed to get thumbnail from local thumbnail cache reference
    at C.formatDownloadItem (C:\Users\martin\AppData\Local\Programs\mattermost-desktop\resources\app.asar\index.js:2:258206)
    at C.upsertFileToDownloads (C:\Users\martin\AppData\Local\Programs\mattermost-desktop\resources\app.asar\index.js:2:255614)
    at C.doneEventController (C:\Users\martin\AppData\Local\Programs\mattermost-desktop\resources\app.asar\index.js:2:256970)
    at DownloadItem.<anonymous> (C:\Users\martin\AppData\Local\Programs\mattermost-desktop\resources\app.asar\index.js:2:254776)
    at Object.onceWrapper (node:events:634:26)
    at DownloadItem.emit (node:events:519:28)

Additional Information

  • Tested on the web interface (current Firefox) and the issue does not show up there.
  • Downloading a different file type (JSON) works, no issues.
  • Downloading an image (PNG) works as well. But here the UX is different, as I first have to click on the image to show it and, when it's shown, I can click the download button shown at the top-right.
@dragonis41
Copy link

My Desktop Mattermost crash too when I try to download a png or jpeg file but the error is different, I don't know if this is related to the same issue.

I'm on Manjaro with kernel 6.10
Mattermost 5.9.0 Desktop

Application: Mattermost 5.9.0 [commit: 5.9.0]
Platform: Linux 6.10.6-10-MANJARO x64
TypeError: s.nativeImage.createThumbnailFromPath is not a function
    at C.formatDownloadItem (/usr/lib/mattermost-desktop/app.asar/index.js:2:258337)
    at C.upsertFileToDownloads (/usr/lib/mattermost-desktop/app.asar/index.js:2:255745)
    at C.doneEventController (/usr/lib/mattermost-desktop/app.asar/index.js:2:257101)
    at DownloadItem.<anonymous> (/usr/lib/mattermost-desktop/app.asar/index.js:2:254907)
    at Object.onceWrapper (node:events:634:26)
    at DownloadItem.emit (node:events:519:28)

@zwolinski
Copy link

The same error appears when downloading *.dwg file.

@plokkingmachine
Copy link

+1

s.nativeImage.createThumbnailFromPath is not a function, app crashes.

@devinbinnie
Copy link
Member

@bjoernmartin I can't reproduce your specific issue, is it consistently reproducing for you everytime? I might need to add a crash check here.

The other issue people are commenting about in this ticket is this one: #3129, which is a separate issue.

@bjoernmartin
Copy link
Author

@devinbinnie yes, happens for SVGs every time.

I just created a new private channel, uploaded another SVG and tried to download it. Same error.

I then downloaded an SVG from the internet, just in case it is something we do with SVGs internally. I chose https://www.svgrepo.com/svg/499714/rocket. No change, still getting the error message on download.

@devinbinnie
Copy link
Member

Thanks @bjoernmartin. I still can't reproduce it, so I'm wondering a couple things:

  • Are you in a managed environment? (ie. is there a group policy configured on you system)
  • Is the file being saved to a network drive? I'm wondering if it's having issues grabbing thumbnails from there.

@bjoernmartin
Copy link
Author

* Are you in a managed environment? (ie. is there a group policy configured on you system)

Nope. I installed the computer myself and my company does not even support managing Windows machines :)

* Is the file being saved to a network drive? I'm wondering if it's having issues grabbing thumbnails from there.

Nope. The installation is local and not tampered with in any way. It runs on a Bitlocker-encrypted system, but I cannot imagine this being an issue here.

@bjoernmartin
Copy link
Author

@zwolinski you mentioned getting "the same" error. This refers to the original one from me?

 Failed to get thumbnail from local thumbnail cache reference

Or the additional one mentioned by @dragonis41 ?

s.nativeImage.createThumbnailFromPath is not a function

Just trying to figure out if I'm the only one with "my" error.

@Annavar-satish
Copy link

Annavar-satish commented Oct 10, 2024

I am Facing the same issue while downloading the jpg,svg etc.,
Mattermost Desktop Version
5.9.0

Operating System
x86_64 GNU/Linux

Mattermost Server Version
CE 9.11.1

Electron Version
31.6.0-2

Looks like Issues with the electron version

Application: Mattermost 5.9.0 [commit: 5.9.0
]
Platform: Linux 6.11.2-zen1-1-zen x64
TypeError: s.nativeImage.createThumbnailFromPath is not a function
    at C.formatDownloadItem (/usr/lib/mattermost-desktop/app.asar/index.js:2:258337)
    at C.upsertFileToDownloads (/usr/lib/mattermost-desktop/app.asar/index.js:2:255745)
    at C.doneEventController (/usr/lib/mattermost-desktop/app.asar/index.js:2:257101)
    at DownloadItem.<anonymous> (/usr/lib/mattermost-desktop/app.asar/index.js:2:254907)
    at Object.onceWrapper (node:events:634:26)
    at DownloadItem.emit (node:events:519:28)

@bjoernmartin
Copy link
Author

@Annavar-satish that is a different issue and got solved via #3129, as stated by @devinbinnie before. That fix is not released yet though (we are still at 5.9.0, 5.9.1 and 5.10.0 should contain the fix).

@licaon-kter
Copy link

So Linux crashes because of #3129 and now Windows crashes because of this one. 😞

@ilippert
Copy link

I looked at an image and then wanted to download it. The download was effective, but the error still occurred. Tested several times. Fedora Linux

Application: Mattermost 5.9.0
Platform: Linux 6.11.4-201.fc40.x86_64 x64
TypeError: s.nativeImage.createThumbnailFromPath is not a function
    at C.formatDownloadItem (/app/main/resources/app.asar/index.js:2:258218)
    at C.upsertFileToDownloads (/app/main/resources/app.asar/index.js:2:255626)
    at C.doneEventController (/app/main/resources/app.asar/index.js:2:256982)
    at DownloadItem.<anonymous> (/app/main/resources/app.asar/index.js:2:254788)
    at Object.onceWrapper (node:events:634:26)
    at DownloadItem.emit (node:events:519:28)

@goutnet
Copy link

goutnet commented Oct 28, 2024

#3188 is very similar in behavior, but on a different platform. I do believe they are related.

@goutnet
Copy link

goutnet commented Oct 29, 2024

After more analysis, it seems we have the same issue on Linux. I close #3188 since it would be a duplicate of this issue, with the same message.

As mentioned above #3188 could also be another instance of #3129, I'll wait for the 5.9.1 to confirm

@devinbinnie
Copy link
Member

#3129 is fixed on v5.10.0-rc.2 if anyone wants to try that.
It might also fix the issue in the screenshot above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants