Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session timeout notification incorrectly says "Days" on iOS #24112

Closed
mattermod opened this issue Jul 25, 2023 · 8 comments · Fixed by mattermost/mattermost-mobile#7629 · May be fixed by mattermost/mattermost-mobile#7510
Closed

Session timeout notification incorrectly says "Days" on iOS #24112

mattermod opened this issue Jul 25, 2023 · 8 comments · Fixed by mattermost/mattermost-mobile#7629 · May be fixed by mattermost/mattermost-mobile#7510
Assignees
@rashmibharambe
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/React Native Mobile app

Comments

@mattermod
Copy link
Contributor

Observed behaviour: When session expires, push notification says, “Please log in to continue receiving notifications. Sessions for test are configured to expire every 1 day.”

Expected behaviour:

  • Notification says, “Please log in to continue receiving notifications. Sessions for test are configured to expire every 1 hour.”
  • Also to update as “hours” if it’s greater than 1 hour.

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-53565
@mattermod mattermod added Help Wanted Community help wanted Up For Grabs labels Jul 25, 2023
@larkox larkox added Difficulty/1:Easy Easy ticket Tech/React Native Mobile app Good First Issue Suitable for first-time contributors labels Jul 25, 2023
@ShisuiMadara
Copy link

Hi, I am interested in solving this one.

@larkox
Copy link
Contributor

larkox commented Aug 7, 2023

@ShisuiMadara All yours 😄

@ShisuiMadara ShisuiMadara mentioned this issue Aug 19, 2023
Open
4 tasks
@whoisgautxm
Copy link

Can I get assigned to this for Hacktober fest

@larkox
Copy link
Contributor

larkox commented Sep 29, 2023 •
edited
Loading

@whoisgautxm Sure! @ShisuiMadara started working on it (you can see the link to the PR in this issue history) but they are not able to finish it. Feel free to take it from where they left it 😄

@larkox larkox assigned whoisgautxm and unassigned ShisuiMadara Sep 29, 2023
@larkox
Copy link
Contributor

larkox commented Oct 19, 2023

@whoisgautxm Are you working on this?

@rashmibharambe
Copy link

@larkox could you please assign this to me. I can work on this issue.

@larkox
Copy link
Contributor

larkox commented Oct 23, 2023

@rashmibharambe All yours. Remember there is some work already done, so feel free to piggyback on that.

@rashmibharambe rashmibharambe mentioned this issue Oct 24, 2023
Merged
4 tasks
@rashmibharambe
Copy link

@rashmibharambe All yours. Remember there is some work already done, so feel free to piggyback on that.

@larkox - I have raised PR, also verified ci/test workflow on fork.
mattermost/mattermost-mobile#7629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rashmibharambe rashmibharambe

Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/React Native Mobile app
Projects
None yet
Milestone
No milestone
5 participants
@larkox @mattermod @ShisuiMadara @rashmibharambe @whoisgautxm