Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RN: Threads list doesn't show channel links #27859

Open
mattermod opened this issue Aug 6, 2024 · 4 comments · May be fixed by mattermost/mattermost-mobile#8205
Open

RN: Threads list doesn't show channel links #27859

mattermod opened this issue Aug 6, 2024 · 4 comments · May be fixed by mattermost/mattermost-mobile#8205
Assignees
@space-w-alker
Labels
Help Wanted Community help wanted

Comments

@mattermod
Copy link
Contributor

Repro steps:

  1. Ensure Collapsed Reply Threads are enabled
  2. Post ~town-square
  3. Reply to that post
  4. In the mobile app, go to Threads

Observed: The post you made is shown as an empty post in the list of threads. If you click on it or see it in a channel, it it contains a link to Town Square.

Expected: The post you made is shown as a clickable link with the channel name (~Town Square) in the list of threads. This behaviour is consistent with the webapp.

Mockup:

Figma file

Note: To maintain consistency across the application, we should also be highlighting mentions in the threads view and make them clickable. This needs to be done in both the mobile app and the webapp, but can be done in a separate effort.

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-58314
@mattermod mattermod added Help Wanted Community help wanted Up For Grabs labels Aug 6, 2024
@space-w-alker
Copy link

@mattermod I'm new here and would like to look into this. But shouldn't this issue be in mattermost-mobile?

@amyblais
Copy link
Member

amyblais commented Sep 5, 2024

Yes, looks like this can be contributed at https://github.com/mattermost/mattermost-mobile.

@space-w-alker
Copy link

@amyblais I have a fix candidate for this issue. But I'm unsure how to submit a pull request since the issue is here and the code change is on mattermost-mobile repo. Should I create a corresponding issue on that project and reference it?

@amyblais
Copy link
Member

amyblais commented Sep 6, 2024

I have a fix candidate for this issue. But I'm unsure how to submit a pull request since the issue is here and the code change is on mattermost-mobile repo. Should I create a corresponding issue on that project and reference it?

Good question, you can submit a pull request to the mobile repo and link to this issue. You don't need to open a new issue in the mobile repo. We tend to open Help Wanted issues in this mattermost repo because it is most active and issues here are most discoverable.

space-w-alker added a commit to space-w-alker/mattermost-mobile that referenced this issue Sep 6, 2024
@space-w-alker
fix: render channel links in threads list
c53b537 
fixes: mattermost/mattermost#27859
@space-w-alker space-w-alker linked a pull request Sep 6, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@space-w-alker space-w-alker

Labels
Help Wanted Community help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: render channel links in threads list space-w-alker/mattermost-mobile
3 participants
@mattermod @amyblais @space-w-alker