Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix screen position for server / login / forgot password & mfa #8340

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

enahum
Copy link
Contributor

@enahum enahum commented Nov 13, 2024

Summary

Fixes the scrolling of the contents of the following screens on iPhone, iPad & Android as part of broken window fixes

  • Server
  • Login
  • Forgot password
  • MFA

Ticket Link

https://mattermost.atlassian.net/browse/MM-56150

Fixes: #8291

Release Note

NONE

@enahum enahum added 2: Dev Review Requires review by a core commiter 2: UX Review Requires review by a UX Designer labels Nov 13, 2024
Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one potential improvement.

app/screens/mfa/index.tsx Outdated Show resolved Hide resolved
@enahum enahum requested a review from larkox November 13, 2024 10:54
Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@matthewbirtch matthewbirtch added the Build Apps for PR Build the mobile app for iOS and Android to test label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core commiter 2: UX Review Requires review by a UX Designer Build Apps for PR Build the mobile app for iOS and Android to test release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

virtual keyboard blocking input field for mfa login on android phone
4 participants