feat(publish): set aptly Origin + Label #59
Conversation
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. /cc @aspleenic |
|
@amyblias Who might be able to review this PR? |
|
@caugner thanks for your contribution and apologies for the delay. I can take a look |
ghost
requested review from
| @@ -4,6 +4,8 @@ set -xeuo pipefail | |||
| release=$1 | |||
| opt=${2:-false} | |||
| nightly=false | |||
| origin="Mattermost" | |||
There was a problem hiding this comment.
Is it possible to fetch origin and label from arguments and make them mandatory?
So that we can distinguish packages by origin. As Mattermost we may want to set origin from CI/CD pipeline to determine officially generated packages. And for anyone who builds and publish to their own repository, they may want to use different origin and label value.
There was a problem hiding this comment.
Is it possible to fetch
originandlabelfrom arguments and make them mandatory?
Currently, the script takes two parameters:
- release
- (optional) opt
Should origin and label be mandatory parameters 2 and 3 as follows:
- release
- origin
- label
- (optional) opt
Or might you prefer to facilitate environment variables APT_RELEASE, APT_ORIGIN and APT_LABEL for this? The script could still fail if those are not set.
There was a problem hiding this comment.
Thank you very much, using enviroment veriables is great idea.
And since we will have multiple parameters, using environment variables will increase readability and flexibility.
./sync-and-publish bionic "Mattermost" "Mattermost Omnibus" --nightly
-vs-
APT_RELEASE="bionic" APT_ORIGIN="Mattermost" APT_LABEL="Mattermost Omnibus" ./sync-and-publish --nightly
It will be nice to use Environment variables and both of them are okay.
Fixes #58.