Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header Button Lacks Icon on Mobile Web #780

Open
ckaznable opened this issue Jun 17, 2024 · 8 comments
Open

Header Button Lacks Icon on Mobile Web #780

ckaznable opened this issue Jun 17, 2024 · 8 comments

Comments

@ckaznable
Copy link

The primary reason for this issue is that the registerCallButtonAction method dispatches both CallButton and MobileChannelHeaderButton simultaneously but does not pass an icon, resulting in this behavior.

Additionally, I have also opened a related issue in the Mattermost repository.
mattermost/mattermost#27359

screenshot:
image

@streamer45
Copy link
Collaborator

@ckaznable I don't believe web view should be a supported way to use this functionality from mobile. It may work, but it wasn't part of the design.

@cpoile @matthewbirtch Thoughts?

@cpoile
Copy link
Member

cpoile commented Jun 17, 2024

I agree.. Perhaps we should not register it on mobile web?

@ckaznable
Copy link
Author

I just checked community.mattermost.com and did not encounter the same issue. Perhaps it's just a configuration issue on my end?

@streamer45
Copy link
Collaborator

@ckaznable Could you share a screenshot of how it would look like when working? I don't remember having a button to start calls in that view.

@ckaznable
Copy link
Author

when I press this button, it triggers the plugin's behavior. After disabling the plugin, the button no longer appears, so I'm sure it's the button from this plugin.

image

@matthewbirtch
Copy link
Contributor

@ckaznable I don't believe web view should be a supported way to use this functionality from mobile. It may work, but it wasn't part of the design.

@cpoile @matthewbirtch Thoughts?

Agreed, plugin actions were not intended to show in the header on mobile web view.

@ckaznable
Copy link
Author

When I use the desktop version and reduce the screen width, this situation also occurs. I think this is not limited to mobile web.

@streamer45
Copy link
Collaborator

Yes, that's exactly the same view, regardless of the device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants