-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header Button Lacks Icon on Mobile Web #780
Comments
@ckaznable I don't believe web view should be a supported way to use this functionality from mobile. It may work, but it wasn't part of the design. @cpoile @matthewbirtch Thoughts? |
I agree.. Perhaps we should not register it on mobile web? |
I just checked community.mattermost.com and did not encounter the same issue. Perhaps it's just a configuration issue on my end? |
@ckaznable Could you share a screenshot of how it would look like when working? I don't remember having a button to start calls in that view. |
Agreed, plugin actions were not intended to show in the header on mobile web view. |
When I use the desktop version and reduce the screen width, this situation also occurs. I think this is not limited to mobile web. |
Yes, that's exactly the same view, regardless of the device. |
The primary reason for this issue is that the
registerCallButtonAction
method dispatches bothCallButton
andMobileChannelHeaderButton
simultaneously but does not pass an icon, resulting in this behavior.Additionally, I have also opened a related issue in the Mattermost repository.
mattermost/mattermost#27359
screenshot:
The text was updated successfully, but these errors were encountered: