Explain in docs not to fill out the Enterprise Base URL config setting if the GH Enterprise instance is hosted on GitHub's domain

[mickmister]

We currently support self-hosted GItHub Enterprise servers with custom URLs, configured with the Enterprise Base URL config setting. If the GH Enterprise instance is hosted by GitHub itself, the correct configuration is to leave the Enterprise Base URL config setting blank, so the plugin uses the default api.github.com host for the GitHub client.

We should make it clear in the following places to have this value blank in the case of GitHub hosting the Enterprise instance, and also rename the setting to Custom GitHub Enterprise URL:

• README.md
• /github setup flow
• plugin config settings page

---

There is also a config setting Enterprise Upload URL, that is always identical to the Enterprise Base URL. I think we should just remove the Enterprise Upload URL since this duplication just causes confusion. We append the suffixes on both of the URLs here

mattermost-plugin-github/server/plugin/plugin.go

Lines 193 to 199 in 573e4a3

	baseURL, _ := url.Parse(config.EnterpriseBaseURL)
	baseURL.Path = path.Join(baseURL.Path, "api", "v3")
	uploadURL, _ := url.Parse(config.EnterpriseUploadURL)
	uploadURL.Path = path.Join(uploadURL.Path, "api", "v3")
	client, err := github.NewEnterpriseClient(baseURL.String(), uploadURL.String(), authenticatedClient)

And we are actually setting up the uploadURL path incorrectly. According to the NewEnterpriseClient function we're calling here https://github.com/google/go-github/blob/466e52f0cd17ddbed7a4ac88307fc8fdaf440605/github/github.go#L378:

• We don't need to apply those suffixes
• It should be /api/uploads anyway

[LREGS]

Can I work on this please?

[mickmister]

Absolutely, thanks @LREGS!