[MM-809]: Fixed the issue of getting errors when using github api with revoked/invalid token #832
+370
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…revoked/invalid token
wiggin77
added
2: Dev Review
|
/update-branch |
|
Error trying to update the PR. |
|
@wiggin77 I have synced this branch with the master |
wiggin77
reviewed
Oct 23, 2024
wiggin77
reviewed
Oct 28, 2024
wiggin77
reviewed
Oct 28, 2024
raghavaggarwal2308
requested changes
Nov 12, 2024
| return nil | ||
| }) | ||
| if cErr != nil { | ||
| return nil, cErr |
There was a problem hiding this comment.
Do we need to log the error here or it is handled somewhere else?
There was a problem hiding this comment.
it is logged from where it is called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
invalid token error, disconnected the user and DMed him to reconnectIssue Link
Fixes #809
Testing steps