Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert sidebar_header component to typescript #431

Open
ayusht2810 opened this issue Dec 28, 2023 · 4 comments · May be fixed by #450
Open

Convert sidebar_header component to typescript #431

ayusht2810 opened this issue Dec 28, 2023 · 4 comments · May be fixed by #450
Assignees
Labels
Help Wanted Community help wanted Typescript Migration Issues that requires typescript migration

Comments

@ayusht2810
Copy link
Contributor

We plan to migrate the gitlab plugin webapp over to TypeScript to facilitate better code quality. This Help Wanted issue is to modify the above mentioned file and associate test files (if the file exists).

Below is a checklist of items you should be doing to migrate:

  • Rename the files to their associated TypeScript extensions (ie. js to ts, jsx to tsx).
  • Add relevant types in the component(s) code.
  • Update any components using those to the correct imports.
  • Fix any errors generated by the TypeScript compiler. You can run rpm run check-types to display any errors.
    We are aiming to be as strict as possible for the time being, but if you run into any issues where the file cannot be successfully migrated without significant change in other libraries, or our tsconfig.json, please feel free to raise them as we are aiming to keep this process smooth and gradual, while enforcing as much as we can.

Some examples of already migrated files can be found here:

@ayusht2810 ayusht2810 added the Help Wanted Community help wanted label Dec 28, 2023
@mickmister mickmister added the Typescript Migration Issues that requires typescript migration label Jan 9, 2024
@Willy-Wakam
Copy link
Contributor

Can I work on this?

@ayusht2810
Copy link
Contributor Author

Thanks, @Willy-Wakam!

@mickmister
Copy link
Member

Hi @Willy-Wakam, I noticed you claimed a few tickets at once. Just touching base and making sure you still want to work on these. Also note that we are in the process of fixing the projects to make the experience better. Thanks for your contributions!

@mickmister
Copy link
Member

@Willy-Wakam Also note that we typically want to have only a small amount of tickets claimed at once by one person, in order to have more available to work on. But as I mentioned, these particular tickets can be made easier to work on first. The core parts of the project and CI need to be fixed and verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Community help wanted Typescript Migration Issues that requires typescript migration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants