Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different Zoom API keys/secrets for different Mattermost Teams #46

Open
yoannspace opened this issue Oct 24, 2019 · 7 comments
Open

Different Zoom API keys/secrets for different Mattermost Teams #46

yoannspace opened this issue Oct 24, 2019 · 7 comments
Labels
Difficulty/2:Medium Medium ticket Hacktoberfest Help Wanted Community help wanted Tech/Go Tech/ReactJS Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers

Comments

@yoannspace
Copy link

Hi,
What if I have a server running with Mattermost and 5 different teams (with users from totally different backgrounds and groups, so 5 very different teams). I want to add the Zoom integration on 2 teams only - each of those teams have their own Zoom accounts (API key / API secret). In the administration and the documentation I can only add one API key/secret and it seems it will be used for all Teams which is not what I would hope for or imagine.
Is there a way to do this? Multiple integration of Zoom depending on the Mattermost teams.
Thanks,
Yoann

@levb levb added the Triage label Oct 28, 2019
@crspeller crspeller removed the Triage label Oct 29, 2019
@levb levb added the Triage label Nov 5, 2019
@yoannspace
Copy link
Author

Dear @levb,
Did you get a chance to discuss this already?
Thanks,
Yoann

@levb levb added Enhancement and removed Triage labels Dec 3, 2019
@levb
Copy link
Contributor

levb commented Dec 3, 2019

We have discussed this, but have no immediate plans to work on this - the current capabilities of the plugin framework do not provide for this functionality easily, and re-building the configuration UI within the plugin itself to support this functionality does not appear well-justified. We would like to develop the capability of having team-specific configurations (with UI) provided by the plugin framework first.

@levb levb added the Needs Mattermost Changes Requires changes to the Mattermost Plugin tookit label Jan 20, 2020
@hanzei hanzei added Type/Enhancement New feature or improvement of existing feature and removed Enhancement labels Mar 7, 2020
@larkox
Copy link
Contributor

larkox commented May 14, 2020

@levb Maybe it is not the best approach, but what about using the settings panel for this? /zoom teamSettings might show a settings panel to configure all this for the current team. As soon as I finish the FreeText for settings, it is easily done.

@larkox
Copy link
Contributor

larkox commented Jan 13, 2021

As a first approach we could do the following:

  • Add a new command only available for sys admins like /zoom teamsettings. This will open a interactive dialog to introduce Client ID, Client Secret and Webhook Secret.
  • If the settings are left blank (or no settings are set) it will use the global settings.
  • For user level apps, make sure to store the tokens separate for each team and global. The same user may connect to different accounts in different teams.
  • Update error messages to denote that you may not be able to connect because you are not connected to this team's Zoom account.

@larkox larkox added Difficulty/2:Medium Medium ticket Help Wanted Community help wanted Tech/Go Tech/ReactJS Up For Grabs Ready for help from the community. Removed when someone volunteers and removed Needs Mattermost Changes Requires changes to the Mattermost Plugin tookit labels Jan 13, 2021
@Mmoushon
Copy link

@larkox my team is looking to take this on. We have a very similar use to @yoannspace, we have a multi-tenant environment so we need the ability for users to link their MM account to different zoom accounts. In your recommended approach above would a user from team X, who has a paid account on MM team X, be able to create a meeting in a MM team Y channel or would they have to have an account on team Y as well?

Also any thoughts on the ability to host multiple zoom severs? We would like to eventually provide users with the ability to "bring your own zoom licenses". Set aside security concerns for a second, is there anything that would stop us technically from just adding "Zoom URL" to the /zoom teamsetting

@larkox
Copy link
Contributor

larkox commented Jun 25, 2021

I will leave @aaronrothschild to make the final decission, but here is my take.

A meeting started from certain team will use the team settings. Therefore, if I belong to two different teams, I would need two different zoom accounts, and connect those two times, one for each team.

Another take, that I like less, but it is also interesting, would be to not tie things to teams, and just define several zoom accounts. That way, when you connect, instead of /zoom connect, you say /zoom connect myCompany. That would allow to map each user to their account, so they can create the zoom room always with their account.

@larkox
Copy link
Contributor

larkox commented Jun 25, 2021

Set aside security concerns for a second, is there anything that would stop us technically from just adding "Zoom URL" to the /zoom teamsetting

If we set security aside, I see no big problem the URL being part of the configuration (either on the teamsettings approach, or the accounts approach).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/2:Medium Medium ticket Hacktoberfest Help Wanted Community help wanted Tech/Go Tech/ReactJS Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet
Development

No branches or pull requests

7 participants