Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the missing transforms to bring parity with patsy / R. #18

Open
4 of 7 tasks
matthewwardrop opened this issue Jul 20, 2020 · 5 comments
Open
4 of 7 tasks

Add the missing transforms to bring parity with patsy / R. #18

matthewwardrop opened this issue Jul 20, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@matthewwardrop
Copy link
Owner

matthewwardrop commented Jul 20, 2020

Formulaic's support for stateful transforms is underutilised. Over the coming couple of weeks I'll be adding support in for the missing transforms, aiming to be compatible with patsy and R implementations.

@matthewwardrop matthewwardrop self-assigned this Jul 20, 2020
@matthewwardrop matthewwardrop added the enhancement New feature or request label Jul 20, 2020
@matthewwardrop matthewwardrop added this to the 0.4.x milestone Oct 17, 2021
@lorentzenchr
Copy link
Contributor

Is the above list up to date? I'm curious if I could be of any help.

@matthewwardrop
Copy link
Owner Author

Hi @lorentzenchr !

Obviously I didn't get to this in the timeline intimated. COVID has led to some changes in various trajectories, including with me heading back to Australia (a big transition given I have four kids). My plan is still to get to this, but you can feel free to explore implementing cr, cc and te if you are interested. I am far more opinionated about the implementation of C.

Note that it was my intention to write these from scratch after learning the mathematics behind them, as I did the others. This allowed me to write things with high performance in mind, and avoid copyright issues.

@lorentzenchr
Copy link
Contributor

Hope you and your family are fine.
In my opinion, C is the most important of all. I'll have a look at the spline basis, let's see.

@lorentzenchr
Copy link
Contributor

I'd be interested in your opinions about C.

@matthewwardrop
Copy link
Owner Author

Hi @lorentzenchr ; sorry... lost the thread here a bit. I've implemented support for different contrast matrices now in #70. Feel free to take a look :).

@matthewwardrop matthewwardrop modified the milestones: 0.3.x, 0.4.x Jun 20, 2022
@matthewwardrop matthewwardrop modified the milestones: 0.4.x, 1.0.x Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants