Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banish .values #47

Open
mattwigway opened this issue Sep 25, 2020 · 0 comments
Open

Banish .values #47

mattwigway opened this issue Sep 25, 2020 · 0 comments

Comments

@mattwigway
Copy link
Owner

Pandas now recommends against using DataFrame.values, as the behavior depends on the dtype of the array. This shouldn't cause a results issue in eqsormo, but could be a perf problem if every access of .values is building big arrays and doing type conversion behind the scenes. For now workaround is to just convert DataFrames to float64 before calling TraSortingModel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant