Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha cannot be specified for critical difference diagram #65

Open
j-adamczyk opened this issue Jan 18, 2024 · 1 comment
Open

Alpha cannot be specified for critical difference diagram #65

j-adamczyk opened this issue Jan 18, 2024 · 1 comment
Assignees
Labels

Comments

@j-adamczyk
Copy link

j-adamczyk commented Jan 18, 2024

Describe the bug

I haven't seen any way to provide alpha (0.05 or 0.1) for plotting critical difference diagram of Nemenyi-Friedman test. I'm trying to follow Demsar's paper link and this tutorial (which sadly uses Orange package), and:

  • "The performance of two classifiers is significantly different if the corresponding average ranks differ by at least the critical difference"
  • "critical values q_α are based on the Studentized range statistic divided by √2", and examples of such values are provided in the paper
  • relevant scikit-posthocs code

So I get the p-values from the test. But looking at CD plotting function, we can see that it uses sign_array() function with constant arguments, which is alpha=0.05. So there is no way to plot CD diagram with any other alpha level. This should be configurable.

@j-adamczyk j-adamczyk added the bug label Jan 18, 2024
@j-adamczyk j-adamczyk changed the title How can alpha be specified for posthoc_nemenyi_friedman? Alpha cannot be specified for critical difference diagram Jan 18, 2024
@maximtrp
Copy link
Owner

Hello! Thank you for pointing at this. This test was based on statsmodels' implementation of Studentized range distribution. It is bound to 0.1, there is no way to specify alpha value. Now we have SciPy's implementation which should be more appropriate here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants