From 9517c89308125e648e520f696df6c664ae3635eb Mon Sep 17 00:00:00 2001 From: Gregory Oschwald Date: Fri, 3 Nov 2023 14:58:19 -0700 Subject: [PATCH] Stop defining PACKAGE_VERSION in public header on Windows --- Changes.md | 2 ++ include/maxminddb.h | 4 ---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/Changes.md b/Changes.md index b17f11ec..e6e3b326 100644 --- a/Changes.md +++ b/Changes.md @@ -2,6 +2,8 @@ * `PACKAGE_VERSION` is now a private compile definition when building with CMake. Pull request by bsergean. GitHub #308. +* `PACKAGE_VERSION` is no longer defined in `maxminddb.h` on + Windows. * The feature test macro `_POSIX_C_SOURCE` is no longer set by `maxminddb.h`. As discussed in GitHub #318, this should be set by applications rather than by libraries. diff --git a/include/maxminddb.h b/include/maxminddb.h index 980abf99..27080669 100644 --- a/include/maxminddb.h +++ b/include/maxminddb.h @@ -16,10 +16,6 @@ extern "C" { #include #include /* libmaxminddb package version from configure */ -#ifndef PACKAGE_VERSION -/* This is used by msbuild. Once we delete those files, we can remove this. */ -#define PACKAGE_VERSION "1.7.1" -#endif typedef ADDRESS_FAMILY sa_family_t;