Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show code analysis errors during build #53

Closed
maxrchung opened this issue Aug 9, 2020 · 0 comments
Closed

Show code analysis errors during build #53

maxrchung opened this issue Aug 9, 2020 · 0 comments

Comments

@maxrchung
Copy link
Owner

maxrchung commented Aug 9, 2020

We should show code analysis reports during the build process. This seems like a pretty new feature of Visual Studio, so there may be some instability. I've tried several solutions provided from this solution, but haven't had much luck: dotnet/roslyn#33558. We may need to wait for a future version of VS for this to be resolved.

For now, before this change, our current procedure should be:

  1. Write code
  2. Analyze > Run Code Analysis
  3. Run code cleanup with all cleanup rules
  4. Fix any remaining errors/warnings shown in error list
  5. Push changes and start pull request
  6. Verify that pipeline passes
  7. Look through build portion of pipeline and fix any noted warnings
  8. Have the other person review
  9. Merge changes
@maxrchung maxrchung changed the title Better CI errors Show code analysis errors during build Aug 9, 2020
@maxrchung maxrchung reopened this Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant