Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to check if all components use the latest OAf #44

Open
alextreme opened this issue Jul 11, 2024 · 7 comments · Fixed by maykinmedia/objects-api#443, maykinmedia/objects-api#460 or maykinmedia/open-klant#274
Assignees
Labels
enhancement New feature or request owner: maykin

Comments

@alextreme
Copy link
Member

Thema / Theme

Other

Omschrijving / Description

With all our registrationcomponents using open-api-framework @joeribekker and I would like to (largely) automate bumping our registrationcomponents to the latest version of OAf. See what's possible, I naively think this would be a matter of running bin/compile_dependancies.sh --update=open-api-framework across all components but this is likely a bit more involved than that...

Toegevoegde waarde / Added value

No response

Aanvullende opmerkingen / Additional context

No response

@alextreme alextreme added enhancement New feature or request triage Triage means the team has not yet refined this issue. labels Jul 11, 2024
@Coperh
Copy link
Contributor

Coperh commented Jul 16, 2024

Edit: can be done in a github aciton

@joeribekker
Copy link
Member

refinmenet: team decides on github action to check if we use the latest version. We should update anyway every period.

@joeribekker joeribekker removed the triage Triage means the team has not yet refined this issue. label Jul 23, 2024
@joeribekker
Copy link
Member

Refinement: Maybe use an existing github action if it exists, or pip install and see if it updated anything, or...

@Coperh
Copy link
Contributor

Coperh commented Sep 24, 2024

Does find errors in the requirements files: https://github.com/maykinmedia/objects-api/actions/runs/11009051505/job/30567882110

Waiting for OAF update to test properly.

Also should eventually be added to open-api-workflows

@joeribekker joeribekker changed the title Script to auto-bump all components using OAf Script to check if all components use the latest OAf Sep 24, 2024
@alextreme
Copy link
Member Author

Change to both scheduled and for each PR to see how annoying this will be

@joeribekker
Copy link
Member

Refinement: Decided to add it to Open Klant to see how the team likes it (or not).

@joeribekker
Copy link
Member

Refinement: Conor will do one more attempt to make automated PRs which update the OAf dep.

We also said that we're not going to do automate patch releases (yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment