Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uitzonderingen beoordelen door recordmanager geeft niet de juiste response #377

Open
SilviaAmAm opened this issue Sep 20, 2024 · 2 comments · May be fixed by #382
Open

Uitzonderingen beoordelen door recordmanager geeft niet de juiste response #377

SilviaAmAm opened this issue Sep 20, 2024 · 2 comments · May be fixed by #382
Assignees
Labels
bug Something isn't working

Comments

@SilviaAmAm
Copy link
Collaborator

SilviaAmAm commented Sep 20, 2024

https://dimpact.atlassian.net/jira/software/c/projects/PZ/boards/258/backlog?selectedIssue=PZ-3968

Currently, if I select "Afwijzen van het voorstel" as an option when processing a review and I then I submit the review response, nothing happens.

Under the hood a 400 error happens when POSTing this json to /api/v1/review-responses/:

{
  "review": 47,
  "comment": "Testtt",
  "itemsResponses": [
    {
      "reviewItem": 28,
      "actionItem": "keep",
      "actionZaak": {
        "selectielijstklasse": "3.1.6 - Vastgesteld - blijvend_bewaren",
        "archiefactiedatum": "2025-07-21"
      },
      "comment": "Test"
    }
  ]
}

The error is:

{
  "itemsResponses": [
    {
      "actionZaak": {
        "selectielijstklasse": [
          "Voer een geldige URL in."
        ]
      }
    }
  ]
}

Expectation

To discuss. What should happen?

This is currently how we handle review responses: https://github.com/maykinmedia/open-archiefbeheer/blob/main/backend/src/openarchiefbeheer/destruction/models.py#L504

  • Do we want the recordmanager to be able to change a zaak when doing "Afwijzen van het voorstel" (if yes, needs to be implemented in the frontend. If no, backend needs updating.) ?
  • Same question about selectielijst and bewaartermijn: currently selecting either option shows both fields
    Screenshot from 2024-09-20 14-48-30

I think that this modal doesn't really make it clear what the actions are 🤔
The action is either "keep zaak in list" or "remove zaak from list" and (independent of it?) change selectielijst and/or bewaartermijn.

@SilviaAmAm SilviaAmAm added bug Something isn't working discuss Further information is requested labels Sep 20, 2024
@KarinMasselink
Copy link

Selectielijstklasse:

  • laten zien welke selectielijstklasse nu geselecteerd is, en uit dropdown nieuwe kunnen kiezen
  • Archiefdatum, op basis van gekozen selectie moet archiefdatum mee veranderen (checken of dit al zo werkt)

Verlengen van bewaartermijn:

  • Geen selectielijstklasse tonen - het is geen aanpassing op de selectielijstklasse.
  • Alleen aanpasbaar archiefdatum veld

Afwijzen:

  • Alleen reden
  • Afwijzen is uitzondering terugdraaien.

@SilviaAmAm
Copy link
Collaborator Author

SilviaAmAm commented Sep 23, 2024

Checked: the zaken on the test environment have a selectielijstklasse defined. But for some reason it is not picked up in the frontend. I will make another issue for this.

New issue: #380

@SilviaAmAm SilviaAmAm removed the discuss Further information is requested label Sep 23, 2024
@SilviaAmAm SilviaAmAm self-assigned this Sep 23, 2024
SilviaAmAm added a commit that referenced this issue Sep 23, 2024
Now we check that an item that is being kept in a list cannot be changed.
We also check that when extending the bewaartermijn, the selectielijstklasse cannot be updated
SilviaAmAm added a commit that referenced this issue Sep 23, 2024
@SilviaAmAm SilviaAmAm linked a pull request Sep 23, 2024 that will close this issue
SilviaAmAm added a commit that referenced this issue Sep 24, 2024
Now we check that an item that is being kept in a list cannot be changed.
We also check that when extending the bewaartermijn, the selectielijstklasse cannot be updated
SilviaAmAm added a commit that referenced this issue Sep 24, 2024
@SilviaAmAm SilviaAmAm changed the title "Afwijzen van het voorstel" when processing review is unclear Uitzonderingen beoordelen door recordmanager geeft niet de juiste response Sep 24, 2024
SilviaAmAm added a commit that referenced this issue Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Has Pull Request
Development

Successfully merging a pull request may close this issue.

2 participants